netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Nick Child <nnac123@linux.ibm.com>
Cc: netdev@vger.kernel.org, nick.child@ibm.com, dave.taht@gmail.com
Subject: Re: [RFC PATCH net-next 0/1] ibmveth: Implement BQL
Date: Tue, 25 Oct 2022 15:10:31 -0700	[thread overview]
Message-ID: <20221025151031.67f06127@kernel.org> (raw)
In-Reply-To: <b4492820-a2d5-7f86-75e4-cb344e050a8f@linux.ibm.com>

On Tue, 25 Oct 2022 15:03:03 -0500 Nick Child wrote:
> Th qdisc is default pfifo_fast.

You need a more advanced qdisc to seen an effect. Try fq.
BQL tries to keep the NIC queue (fifo) as short as possible
to hold packets in the qdisc. But if the qdisc is also just
a fifo there's no practical difference.

I have no practical experience with BQL on virtualized NICs 
tho, so unsure what gains you should expect to see..

  reply	other threads:[~2022-10-25 22:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24 21:38 [RFC PATCH net-next 0/1] ibmveth: Implement BQL Nick Child
2022-10-24 21:38 ` [RFC PATCH net-next 1/1] " Nick Child
2022-10-25 18:41 ` [RFC PATCH net-next 0/1] " Jakub Kicinski
2022-10-25 20:03   ` Nick Child
2022-10-25 22:10     ` Jakub Kicinski [this message]
2022-10-26  0:08       ` Dave Taht
2022-10-26 21:10         ` Nick Child

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221025151031.67f06127@kernel.org \
    --to=kuba@kernel.org \
    --cc=dave.taht@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nick.child@ibm.com \
    --cc=nnac123@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).