From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BDA7ECDFA1 for ; Tue, 25 Oct 2022 23:08:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232725AbiJYXIE (ORCPT ); Tue, 25 Oct 2022 19:08:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232107AbiJYXID (ORCPT ); Tue, 25 Oct 2022 19:08:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25428E985F; Tue, 25 Oct 2022 16:08:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C2DDE61BA9; Tue, 25 Oct 2022 23:08:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE94DC433C1; Tue, 25 Oct 2022 23:08:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666739282; bh=pn3rcfbfIfY0TEQWDwy84ohmjEImsqQ+lTPswiWJZe0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TeCh6hlxLll3D83hsiAjAoX+3amar3OSKDICsDxNhgQsXDO/60jwm2LNbp2PC5F/2 5YLSVXxAuhYU11m56HbZt0M93mTbUqpFINL9Bfz/JxkFkNmkKNjQPx1RFhG6BnBR/i lXWdeySWCTyh9gj9bPjAuqIWg3pNQo1nArVr3YNuWYov+M+9qCx0JU0KrKoY7ah1Fb POB5bnjAzcl/kiW/J/YUmzmfHmObEUghVeHujNk56LjXQs0W/cKcUMzonQIFAu+wco dW/V52rDujz7CmBleUg1SKGTukFVcORlLfWH70hdMyR4Z6GH7wcxu5Swf5ZzbQFwTx yZJu4cmja8icA== Date: Tue, 25 Oct 2022 16:08:00 -0700 From: Jakub Kicinski To: Andrew Lunn , Juergen Borleis Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH v2] net: fec: limit register access on i.MX6UL Message-ID: <20221025160800.4eda6f50@kernel.org> In-Reply-To: References: <20221024080552.21004-1-jbe@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 25 Oct 2022 14:49:45 +0200 Andrew Lunn wrote: > On Mon, Oct 24, 2022 at 10:05:52AM +0200, Juergen Borleis wrote: > > Using 'ethtool -d [=E2=80=A6]' on an i.MX6UL leads to a kernel crash: > >=20 > > Unhandled fault: external abort on non-linefetch (0x1008) at [=E2=80= =A6] > >=20 > > due to this SoC has less registers in its FEC implementation compared t= o other > > i.MX6 variants. Thus, a run-time decision is required to avoid access to > > non-existing registers. > >=20 > > Signed-off-by: Juergen Borleis =20 >=20 > Reviewed-by: Andrew Lunn What would be the right Fixes tag for this? This one perhaps? Fixes: a51d3ab50702 ("net: fec: use a more proper compatible string for i.M= X6UL type device")