From: Saeed Mahameed <saeed@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH net-next v1 0/6] Various cleanups for mlx5
Date: Wed, 26 Oct 2022 15:27:31 +0100 [thread overview]
Message-ID: <20221026142731.nrmhssgn5dhi7jot@sx1> (raw)
In-Reply-To: <Y1fHq9HVOhgeNhlB@unreal>
On 25 Oct 14:25, Leon Romanovsky wrote:
>On Tue, Oct 25, 2022 at 12:00:11PM +0100, Saeed Mahameed wrote:
>> On 24 Oct 19:59, Leon Romanovsky wrote:
>> > From: Leon Romanovsky <leonro@nvidia.com>
>> >
>> > Changelog:
>> > v1:
>> > Patch #1:
>> > * Removed extra blank line
>> > * Removed ipsec initialization for uplink
>>
>> This will break functionality, ipsec should only be enabled on nic and
>> uplink but not on other vport representors.
>
>I didn't hear any complain from verification. The devlink patch is in
>my tree for months already.
>
the regression is clear in the code. Ask Raed he added the functionality
for uplink.
>>
>> Leon let's finish review internally, this series has to go through my trees
>> anyways.
>
>What about other 5 patches? Let's progress with them, please.
>
Sure, I will take other patches into my tree, but please let's do internal
reviews next time, no need to clutter ML with mlx5 specific stuff.
next prev parent reply other threads:[~2022-10-26 14:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 16:59 [PATCH net-next v1 0/6] Various cleanups for mlx5 Leon Romanovsky
2022-10-24 16:59 ` [PATCH net-next v1 1/6] net/mlx5e: Support devlink reload of IPsec core Leon Romanovsky
2022-10-25 10:58 ` Saeed Mahameed
2022-10-24 16:59 ` [PATCH net-next v1 2/6] net/mlx5: Return ready to use ASO WQE Leon Romanovsky
2022-10-24 16:59 ` [PATCH net-next v1 3/6] net/mlx5e: Don't access directly DMA device pointer Leon Romanovsky
2022-10-24 16:59 ` [PATCH net-next v1 4/6] net/mlx5e: Delete always true DMA check Leon Romanovsky
2022-10-24 16:59 ` [PATCH net-next v1 5/6] net/mlx5: Remove redundant check Leon Romanovsky
2022-10-24 16:59 ` [PATCH net-next v1 6/6] net/mlx5e: Use read lock for eswitch get callbacks Leon Romanovsky
2022-10-25 11:00 ` [PATCH net-next v1 0/6] Various cleanups for mlx5 Saeed Mahameed
2022-10-25 11:25 ` Leon Romanovsky
2022-10-26 14:27 ` Saeed Mahameed [this message]
2022-10-27 6:07 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221026142731.nrmhssgn5dhi7jot@sx1 \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox