From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8801EC38A2D for ; Thu, 27 Oct 2022 03:40:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234399AbiJ0Dkk (ORCPT ); Wed, 26 Oct 2022 23:40:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234471AbiJ0Dk0 (ORCPT ); Wed, 26 Oct 2022 23:40:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8C3E2CCA2; Wed, 26 Oct 2022 20:40:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 608E262157; Thu, 27 Oct 2022 03:40:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5531AC433C1; Thu, 27 Oct 2022 03:40:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666842018; bh=GyIfj4IMk1Z0HBO58cMK4cGISzPvw+zc6MisDvaFk9w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U63FD2C3f+mnxAKh3hmd8a/fk7vemt+nCfPUkcwTmluNTTYDZ7bHp8AzkAfV6woPP wsNubL1QFMGF/2xOixBO4rPTPYw6ngwwUokk4Do/487B1s6Z10IgsaTCHEZo9KLgG+ EWGhGwoHIxoRzcwsWUq59pzDIncTDLriTgs3+cffVTF5F92kTjXb/2d1msfyJYB2yy 04xlO61IbgysK8TBX9qB13YXRmjQXuYrYItjiIkIYQrTgwwq4ZOJhQtqr132TKcKey YXwfSXfQvkzK4pbos3J4CtlYG/dib7VAGM2v0RIj/+BV0HA+jrwK8HIzwadaZvG/2A OIA2ys4fPDhuA== Date: Wed, 26 Oct 2022 20:40:17 -0700 From: Jakub Kicinski To: Alexandru Tachici Cc: , , , , , , , Subject: Re: [net v3 1/1] net: ethernet: adi: adin1110: Fix notifiers Message-ID: <20221026204017.0a0afff5@kernel.org> In-Reply-To: <20221025075227.9276-2-alexandru.tachici@analog.com> References: <20221025075227.9276-1-alexandru.tachici@analog.com> <20221025075227.9276-2-alexandru.tachici@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 25 Oct 2022 10:52:27 +0300 Alexandru Tachici wrote: > + int err; > + > + err = adin1110_setup_notifiers(); > + if (err) > + return err; > + > + return spi_register_driver(&adin1110_driver); What unregisters the notifies if spi_register_driver() fails, now?