From: Jakub Kicinski <kuba@kernel.org>
To: Michal Wilczynski <michal.wilczynski@intel.com>
Cc: netdev@vger.kernel.org, alexandr.lobakin@intel.com,
jacob.e.keller@intel.com, jesse.brandeburg@intel.com,
przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com,
ecree.xilinx@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH net-next v7 9/9] ice: Prevent ADQ, DCB, RDMA coexistence with Custom Tx scheduler
Date: Thu, 27 Oct 2022 20:28:52 -0700 [thread overview]
Message-ID: <20221027202852.5be21498@kernel.org> (raw)
In-Reply-To: <20221027130049.2418531-10-michal.wilczynski@intel.com>
On Thu, 27 Oct 2022 15:00:49 +0200 Michal Wilczynski wrote:
> ADQ, DCB, RDMA might interfere with Custom Tx Scheduler changes that user
> might introduce using devlink-rate API.
>
> Check if ADQ, DCB, RDMA is active, when user tries to change any setting
> in exported Tx scheduler tree. If any of those are active block the user
> from doing so, and log an appropriate message.
drivers/net/ethernet/intel/ice/ice_devlink.c:727: warning: Excess function parameter 'extack' description in 'ice_enable_custom_tx'
prev parent reply other threads:[~2022-10-28 3:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 13:00 [PATCH net-next v7 0/9] Implement devlink-rate API and extend it Michal Wilczynski
2022-10-27 13:00 ` [PATCH net-next v7 1/9] devlink: Introduce new parameter 'tx_priority' to devlink-rate Michal Wilczynski
2022-10-27 13:00 ` [PATCH net-next v7 2/9] devlink: Introduce new parameter 'tx_weight' " Michal Wilczynski
2022-10-27 13:00 ` [PATCH net-next v7 3/9] devlink: Enable creation of the devlink-rate nodes from the driver Michal Wilczynski
2022-10-27 21:27 ` Przemek Kitszel
2022-10-28 8:51 ` Wilczynski, Michal
2022-10-27 13:00 ` [PATCH net-next v7 4/9] devlink: Allow for devlink-rate nodes parent reassignment Michal Wilczynski
2022-10-27 22:34 ` Przemek Kitszel
2022-10-28 9:35 ` Wilczynski, Michal
2022-10-27 13:00 ` [PATCH net-next v7 5/9] devlink: Allow to set up parent in devl_rate_leaf_create() Michal Wilczynski
2022-10-28 3:28 ` Jakub Kicinski
2022-10-27 13:00 ` [PATCH net-next v7 6/9] devlink: Allow to change priv in devlink-rate from parent_set callbacks Michal Wilczynski
2022-10-27 13:00 ` [PATCH net-next v7 7/9] ice: Introduce new parameters in ice_sched_node Michal Wilczynski
2022-10-27 13:00 ` [PATCH net-next v7 8/9] ice: Implement devlink-rate API Michal Wilczynski
2022-10-27 13:00 ` [PATCH net-next v7 9/9] ice: Prevent ADQ, DCB, RDMA coexistence with Custom Tx scheduler Michal Wilczynski
2022-10-28 3:28 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221027202852.5be21498@kernel.org \
--to=kuba@kernel.org \
--cc=alexandr.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ecree.xilinx@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@resnulli.us \
--cc=michal.wilczynski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).