From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>,
Robert Marko <robert.marko@sartura.hr>,
Michael Walle <michael@walle.cc>,
devicetree@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
Russell King <linux@armlinux.org.uk>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
linux-kernel@vger.kernel.org, Marcin Wojtas <mw@semihalf.com>,
Eric Dumazet <edumazet@google.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/5] dt-bindings: nvmem: add YAML schema for the ONIE tlv layout
Date: Fri, 28 Oct 2022 15:44:31 +0200 [thread overview]
Message-ID: <20221028154431.0096ab70@xps-13> (raw)
In-Reply-To: <166695949292.1076993.16137208250373047416.robh@kernel.org>
Hi Rob & Krzysztof,
robh@kernel.org wrote on Fri, 28 Oct 2022 07:20:05 -0500:
> On Fri, 28 Oct 2022 11:23:34 +0200, Miquel Raynal wrote:
> > Add a schema for the ONIE tlv NVMEM layout that can be found on any ONIE
> > compatible networking device.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > .../nvmem/layouts/onie,tlv-layout.yaml | 96 +++++++++++++++++++
> > 1 file changed, 96 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/onie,tlv-layout.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/nvmem/layouts/onie,tlv-layout.example.dtb:0:0: /example-0/onie: failed to match any schema with compatible: ['onie,tlv-layout', 'vendor,device']
Oh right, I wanted to ask about this under the three --- but I forgot.
Here was my question:
How do we make the checker happy with an example where the second
compatible can be almost anything (any nvmem-compatible device) but the
first one should be the layout? (this is currently what Michael's
proposal uses).
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
Thanks,
Miquèl
next prev parent reply other threads:[~2022-10-28 13:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 9:23 [PATCH 0/5] ONIE tlv nvmem layout support Miquel Raynal
2022-10-28 9:23 ` [PATCH 1/5] dt-bindings: vendor-prefixes: Add ONIE Miquel Raynal
2022-10-31 17:50 ` Rob Herring
2022-10-28 9:23 ` [PATCH 2/5] dt-bindings: nvmem: add YAML schema for the ONIE tlv layout Miquel Raynal
2022-10-28 12:20 ` Rob Herring
2022-10-28 13:44 ` Miquel Raynal [this message]
2022-10-28 21:35 ` Rob Herring
2022-11-04 10:56 ` Miquel Raynal
2022-10-28 9:23 ` [PATCH 3/5] nvmem: layouts: Add ONIE tlv layout driver Miquel Raynal
2022-10-28 9:23 ` [PATCH 4/5] MAINTAINERS: Add myself as ONIE tlv NVMEM layout maintainer Miquel Raynal
2022-10-28 9:23 ` [PATCH 5/5] net: mvpp2: Consider NVMEM cells as possible MAC address source Miquel Raynal
2022-10-28 13:33 ` Michael Walle
2022-11-02 14:33 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221028154431.0096ab70@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=michael@walle.cc \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).