From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DD93FA3742 for ; Mon, 31 Oct 2022 02:17:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229629AbiJaCRg (ORCPT ); Sun, 30 Oct 2022 22:17:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbiJaCRg (ORCPT ); Sun, 30 Oct 2022 22:17:36 -0400 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 183BAA19A; Sun, 30 Oct 2022 19:17:33 -0700 (PDT) Date: Mon, 31 Oct 2022 10:17:27 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1667182651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rLdOzQqx2fzRkNdpZUCQBiywsSd0hKCCe/A8G0/1MqE=; b=SXxylHckHuLL0or/9YgnW+SNJvfR+vuxkx0tdzZ1ktz0el2C/JfFXKXhBw+DIe1THskFmm BgL69htdBNstx/LezIbKw1TbS4ZwAhpLvjc1dfUPKy1Ott/XyWFND5vOWrsf7xYwBHR2Z3 yIFmohiXDek6bzvmDg5AfheNtOJPr+Q= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Cai Huoqing To: Jakub Kicinski Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Zhengchao Shao , Bin Chen , Alexei Starovoitov , Greg Kroah-Hartman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable Message-ID: <20221031021727.GA9517@chq-T47> References: <20221026125922.34080-1-cai.huoqing@linux.dev> <20221027110241.0340abdf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221027110241.0340abdf@kernel.org> X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 27 10月 22 11:02:41, Jakub Kicinski wrote: > On Wed, 26 Oct 2022 20:59:10 +0800 Cai Huoqing wrote: > > Subject: [PATCH 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable > > Please put [PATCH net-next] or [PATCH -next] in the subject, > to make the patch sorting easier for maintainers. > > > The print cmd code is in hex, so using hex cmd code intead of > > decimal is easy to check the value with print info. > > > - HINIC_PORT_CMD_SET_AUTONEG = 219, > > - > > - HINIC_PORT_CMD_GET_STD_SFP_INFO = 240, > > - > > - HINIC_PORT_CMD_SET_LRO_TIMER = 244, > > - > > - HINIC_PORT_CMD_SET_VF_MAX_MIN_RATE = 249, > > - > > - HINIC_PORT_CMD_GET_SFP_ABS = 251, > > + HINIC_PORT_CMD_GET_SFP_ABS = 0xFB, > > This deletes some entries. Please don't mix changes with mechanical > conversions. After checking my patch again, these can be find, + HINIC_PORT_CMD_SET_AUTONEG = 0xDB, + HINIC_PORT_CMD_GET_STD_SFP_INFO = 0xF0, + HINIC_PORT_CMD_SET_LRO_TIMER = 0xF4, + HINIC_PORT_CMD_SET_VF_MAX_MIN_RATE = 0xF9,