From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>,
Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [PATCH net-next] ethtool: Fail number of channels change when it conflicts with rxnfc
Date: Mon, 31 Oct 2022 18:23:48 -0700 [thread overview]
Message-ID: <20221031182348.3e8ddb4e@kernel.org> (raw)
In-Reply-To: <20221031100016.6028-1-gal@nvidia.com>
On Mon, 31 Oct 2022 12:00:16 +0200 Gal Pressman wrote:
> Similar to what we do with the hash indirection table [1], when network
> flow classification rules are forwarding traffic to channels greater
> than the requested number of channels, fail the operation.
> Without this, traffic could be directed to channels which no longer
> exist (dropped) after changing number of channels.
>
> [1] commit d4ab4286276f ("ethtool: correctly ensure {GS}CHANNELS doesn't conflict with GS{RXFH}")
Have you made sure there are no magic encodings of queue numbers this
would break? I seem to recall some vendors used magic queue values to
redirect to VFs before TC and switchdev. If that's the case we'd need
to locate the drivers that do that and flag them so we can enforce this
only going forward?
next prev parent reply other threads:[~2022-11-01 1:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 10:00 [PATCH net-next] ethtool: Fail number of channels change when it conflicts with rxnfc Gal Pressman
2022-11-01 1:23 ` Jakub Kicinski [this message]
2022-11-01 16:50 ` Jacob Keller
2022-11-02 12:44 ` Gal Pressman
2022-11-02 19:38 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221031182348.3e8ddb4e@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=gal@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).