From: Jakub Kicinski <kuba@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-can@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH net-next 0/14] pull-request: can-next 2022-10-31
Date: Mon, 31 Oct 2022 20:27:14 -0700 [thread overview]
Message-ID: <20221031202714.1eada551@kernel.org> (raw)
In-Reply-To: <20221031154406.259857-1-mkl@pengutronix.de>
On Mon, 31 Oct 2022 16:43:52 +0100 Marc Kleine-Budde wrote:
> The first 7 patches are by Stephane Grosjean and Lukas Magel and
> target the peak_usb driver. Support for flashing a user defined device
> ID via the ethtool flash interface is added. A read only sysfs
nit: ethtool eeprom set != ethtool flash
> attribute for that value is added to distinguish between devices via
> udev.
So the user can write an arbitrary u32 value into flash which then
persistently pops up in sysfs across reboots (as a custom attribute
called "user_devid")?
I don't know.. the whole thing strikes me as odd. Greg do you have any
feelings about such.. solutions?
patches 5 and 6 here:
https://lore.kernel.org/all/20221031154406.259857-1-mkl@pengutronix.de/
next prev parent reply other threads:[~2022-11-01 3:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 15:43 [PATCH net-next 0/14] pull-request: can-next 2022-10-31 Marc Kleine-Budde
2022-10-31 15:43 ` [PATCH net-next 01/14] can: peak_usb: rename device_id to a more explicit name Marc Kleine-Budde
2022-10-31 15:43 ` [PATCH net-next 02/14] can: peak_usb: add callback to read user value of CANFD devices Marc Kleine-Budde
2022-10-31 15:43 ` [PATCH net-next 03/14] can: peak_usb: allow flashing of the user device id Marc Kleine-Budde
2022-10-31 15:43 ` [PATCH net-next 04/14] can: peak_usb: replace unregister_netdev() with unregister_candev() Marc Kleine-Budde
2022-10-31 15:43 ` [PATCH net-next 05/14] can: peak_usb: add ethtool interface to user defined flashed device number Marc Kleine-Budde
2022-10-31 15:43 ` [PATCH net-next 06/14] can: peak_usb: export PCAN user device ID as sysfs device attribute Marc Kleine-Budde
2022-10-31 15:43 ` [PATCH net-next 07/14] can: peak_usb: align user device id format in log with sysfs attribute Marc Kleine-Budde
2022-10-31 15:44 ` [PATCH net-next 08/14] can: kvaser_usb: kvaser_usb_set_bittiming(): fix redundant initialization warning for err Marc Kleine-Budde
2022-10-31 15:44 ` [PATCH net-next 09/14] can: kvaser_usb: kvaser_usb_set_{,data}bittiming(): remove empty lines in variable declaration Marc Kleine-Budde
2022-10-31 15:44 ` [PATCH net-next 10/14] can: rcar_canfd: rcar_canfd_probe: Add struct rcar_canfd_hw_info to driver data Marc Kleine-Budde
2022-10-31 15:44 ` [PATCH net-next 11/14] can: rcar_canfd: Add max_channels to struct rcar_canfd_hw_info Marc Kleine-Budde
2022-10-31 15:44 ` [PATCH net-next 12/14] can: rcar_canfd: Add shared_global_irqs " Marc Kleine-Budde
2022-10-31 15:44 ` [PATCH net-next 13/14] can: rcar_canfd: Add postdiv " Marc Kleine-Budde
2022-10-31 15:44 ` [PATCH net-next 14/14] can: rcar_canfd: Add multi_channel_irqs " Marc Kleine-Budde
2022-11-01 3:27 ` Jakub Kicinski [this message]
2022-11-01 5:06 ` [PATCH net-next 0/14] pull-request: can-next 2022-10-31 Greg Kroah-Hartman
2022-11-04 13:08 ` Marc Kleine-Budde
2022-11-04 14:53 ` Greg Kroah-Hartman
2022-11-08 19:07 ` Lukas Magel
2022-11-01 8:26 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221031202714.1eada551@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).