* [PATCH net-next 0/5] sfc: add basic flower matches to offload
@ 2022-10-24 9:29 edward.cree
2022-10-24 9:29 ` [PATCH net-next 1/5] sfc: check recirc_id match caps before MAE offload edward.cree
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: edward.cree @ 2022-10-24 9:29 UTC (permalink / raw)
To: netdev, linux-net-drivers
Cc: davem, kuba, pabeni, edumazet, habetsm.xilinx, Edward Cree
From: Edward Cree <ecree.xilinx@gmail.com>
Support offloading TC flower rules with matches on L2-L4 fields.
Edward Cree (5):
sfc: check recirc_id match caps before MAE offload
sfc: add Layer 2 matches to ef100 TC offload
sfc: add Layer 3 matches to ef100 TC offload
sfc: add Layer 3 flag matches to ef100 TC offload
sfc: add Layer 4 matches to ef100 TC offload
drivers/net/ethernet/sfc/mae.c | 132 ++++++++++++++++++++++++++++++
drivers/net/ethernet/sfc/mcdi.h | 12 +++
drivers/net/ethernet/sfc/tc.c | 137 +++++++++++++++++++++++++++++---
drivers/net/ethernet/sfc/tc.h | 16 ++++
4 files changed, 286 insertions(+), 11 deletions(-)
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH net-next 1/5] sfc: check recirc_id match caps before MAE offload
2022-10-24 9:29 [PATCH net-next 0/5] sfc: add basic flower matches to offload edward.cree
@ 2022-10-24 9:29 ` edward.cree
2022-10-26 2:40 ` Jakub Kicinski
2022-10-24 9:29 ` [PATCH net-next 2/5] sfc: add Layer 2 matches to ef100 TC offload edward.cree
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: edward.cree @ 2022-10-24 9:29 UTC (permalink / raw)
To: netdev, linux-net-drivers
Cc: davem, kuba, pabeni, edumazet, habetsm.xilinx, Edward Cree
From: Edward Cree <ecree.xilinx@gmail.com>
Offloaded TC rules always match on recirc_id in the MAE, so we should
check that the MAE reported support for this match before attempting
to insert the rule.
Fixes: d902e1a737d4 ("sfc: bare bones TC offload on EF100")
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
---
drivers/net/ethernet/sfc/mae.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/net/ethernet/sfc/mae.c b/drivers/net/ethernet/sfc/mae.c
index 6f472ea0638a..4ceb8c8f5548 100644
--- a/drivers/net/ethernet/sfc/mae.c
+++ b/drivers/net/ethernet/sfc/mae.c
@@ -250,6 +250,21 @@ static int efx_mae_match_check_cap_typ(u8 support, enum mask_type typ)
}
}
+/* Validate field mask against hardware capabilities. May return from caller */
+#define CHECK(_mcdi, _field) do { \
+ enum mask_type typ = classify_mask((const u8 *)&mask->_field, \
+ sizeof(mask->_field)); \
+ \
+ rc = efx_mae_match_check_cap_typ(supported_fields[MAE_FIELD_ ## _mcdi],\
+ typ); \
+ if (rc) { \
+ NL_SET_ERR_MSG_FMT_MOD(extack, \
+ "No support for %s mask in field %s", \
+ mask_type_name(typ), #_field); \
+ return rc; \
+ } \
+} while (0)
+
int efx_mae_match_check_caps(struct efx_nic *efx,
const struct efx_tc_match_fields *mask,
struct netlink_ext_ack *extack)
@@ -269,6 +284,7 @@ int efx_mae_match_check_caps(struct efx_nic *efx,
mask_type_name(ingress_port_mask_type));
return rc;
}
+ CHECK(RECIRC_ID, recirc_id);
return 0;
}
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH net-next 2/5] sfc: add Layer 2 matches to ef100 TC offload
2022-10-24 9:29 [PATCH net-next 0/5] sfc: add basic flower matches to offload edward.cree
2022-10-24 9:29 ` [PATCH net-next 1/5] sfc: check recirc_id match caps before MAE offload edward.cree
@ 2022-10-24 9:29 ` edward.cree
2022-10-24 9:29 ` [PATCH net-next 3/5] sfc: add Layer 3 " edward.cree
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: edward.cree @ 2022-10-24 9:29 UTC (permalink / raw)
To: netdev, linux-net-drivers
Cc: davem, kuba, pabeni, edumazet, habetsm.xilinx, Edward Cree
From: Edward Cree <ecree.xilinx@gmail.com>
Support matching on EtherType, VLANs and ethernet source/destination
addresses, with masking if supported by the hardware.
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
---
drivers/net/ethernet/sfc/mae.c | 36 +++++++++++++++++++
drivers/net/ethernet/sfc/mcdi.h | 6 ++++
drivers/net/ethernet/sfc/tc.c | 62 ++++++++++++++++++++++++++++++---
drivers/net/ethernet/sfc/tc.h | 4 +++
4 files changed, 103 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/sfc/mae.c b/drivers/net/ethernet/sfc/mae.c
index 4ceb8c8f5548..e119bc61ced7 100644
--- a/drivers/net/ethernet/sfc/mae.c
+++ b/drivers/net/ethernet/sfc/mae.c
@@ -284,9 +284,17 @@ int efx_mae_match_check_caps(struct efx_nic *efx,
mask_type_name(ingress_port_mask_type));
return rc;
}
+ CHECK(ETHER_TYPE, eth_proto);
+ CHECK(VLAN0_TCI, vlan_tci[0]);
+ CHECK(VLAN0_PROTO, vlan_proto[0]);
+ CHECK(VLAN1_TCI, vlan_tci[1]);
+ CHECK(VLAN1_PROTO, vlan_proto[1]);
+ CHECK(ETH_SADDR, eth_saddr);
+ CHECK(ETH_DADDR, eth_daddr);
CHECK(RECIRC_ID, recirc_id);
return 0;
}
+#undef CHECK
static bool efx_mae_asl_id(u32 id)
{
@@ -459,6 +467,34 @@ static int efx_mae_populate_match_criteria(MCDI_DECLARE_STRUCT_PTR(match_crit),
match->value.recirc_id);
MCDI_STRUCT_SET_BYTE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_RECIRC_ID_MASK,
match->mask.recirc_id);
+ MCDI_STRUCT_SET_WORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_ETHER_TYPE_BE,
+ match->value.eth_proto);
+ MCDI_STRUCT_SET_WORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_ETHER_TYPE_BE_MASK,
+ match->mask.eth_proto);
+ MCDI_STRUCT_SET_WORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_VLAN0_TCI_BE,
+ match->value.vlan_tci[0]);
+ MCDI_STRUCT_SET_WORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_VLAN0_TCI_BE_MASK,
+ match->mask.vlan_tci[0]);
+ MCDI_STRUCT_SET_WORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_VLAN0_PROTO_BE,
+ match->value.vlan_proto[0]);
+ MCDI_STRUCT_SET_WORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_VLAN0_PROTO_BE_MASK,
+ match->mask.vlan_proto[0]);
+ MCDI_STRUCT_SET_WORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_VLAN1_TCI_BE,
+ match->value.vlan_tci[1]);
+ MCDI_STRUCT_SET_WORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_VLAN1_TCI_BE_MASK,
+ match->mask.vlan_tci[1]);
+ MCDI_STRUCT_SET_WORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_VLAN1_PROTO_BE,
+ match->value.vlan_proto[1]);
+ MCDI_STRUCT_SET_WORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_VLAN1_PROTO_BE_MASK,
+ match->mask.vlan_proto[1]);
+ memcpy(MCDI_STRUCT_PTR(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_ETH_SADDR_BE),
+ match->value.eth_saddr, ETH_ALEN);
+ memcpy(MCDI_STRUCT_PTR(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_ETH_SADDR_BE_MASK),
+ match->mask.eth_saddr, ETH_ALEN);
+ memcpy(MCDI_STRUCT_PTR(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_ETH_DADDR_BE),
+ match->value.eth_daddr, ETH_ALEN);
+ memcpy(MCDI_STRUCT_PTR(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_ETH_DADDR_BE_MASK),
+ match->mask.eth_daddr, ETH_ALEN);
return 0;
}
diff --git a/drivers/net/ethernet/sfc/mcdi.h b/drivers/net/ethernet/sfc/mcdi.h
index 1f18e9dc62e8..883a4db695e2 100644
--- a/drivers/net/ethernet/sfc/mcdi.h
+++ b/drivers/net/ethernet/sfc/mcdi.h
@@ -224,6 +224,12 @@ void efx_mcdi_sensor_event(struct efx_nic *efx, efx_qword_t *ev);
#define MCDI_WORD(_buf, _field) \
((u16)BUILD_BUG_ON_ZERO(MC_CMD_ ## _field ## _LEN != 2) + \
le16_to_cpu(*(__force const __le16 *)MCDI_PTR(_buf, _field)))
+/* Write a 16-bit field defined in the protocol as being big-endian. */
+#define MCDI_STRUCT_SET_WORD_BE(_buf, _field, _value) do { \
+ BUILD_BUG_ON(_field ## _LEN != 2); \
+ BUILD_BUG_ON(_field ## _OFST & 1); \
+ *(__force __be16 *)MCDI_STRUCT_PTR(_buf, _field) = (_value); \
+ } while (0)
#define MCDI_SET_DWORD(_buf, _field, _value) \
EFX_POPULATE_DWORD_1(*_MCDI_DWORD(_buf, _field), EFX_DWORD_0, _value)
#define MCDI_STRUCT_SET_DWORD(_buf, _field, _value) \
diff --git a/drivers/net/ethernet/sfc/tc.c b/drivers/net/ethernet/sfc/tc.c
index b21a961eabb1..b469a1263211 100644
--- a/drivers/net/ethernet/sfc/tc.c
+++ b/drivers/net/ethernet/sfc/tc.c
@@ -124,6 +124,20 @@ static void efx_tc_flow_free(void *ptr, void *arg)
kfree(rule);
}
+/* Boilerplate for the simple 'copy a field' cases */
+#define _MAP_KEY_AND_MASK(_name, _type, _tcget, _tcfield, _field) \
+if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_##_name)) { \
+ struct flow_match_##_type fm; \
+ \
+ flow_rule_match_##_tcget(rule, &fm); \
+ match->value._field = fm.key->_tcfield; \
+ match->mask._field = fm.mask->_tcfield; \
+}
+#define MAP_KEY_AND_MASK(_name, _type, _tcfield, _field) \
+ _MAP_KEY_AND_MASK(_name, _type, _type, _tcfield, _field)
+#define MAP_ENC_KEY_AND_MASK(_name, _type, _tcget, _tcfield, _field) \
+ _MAP_KEY_AND_MASK(ENC_##_name, _type, _tcget, _tcfield, _field)
+
static int efx_tc_flower_parse_match(struct efx_nic *efx,
struct flow_rule *rule,
struct efx_tc_match *match,
@@ -144,26 +158,64 @@ static int efx_tc_flower_parse_match(struct efx_nic *efx,
}
if (dissector->used_keys &
~(BIT(FLOW_DISSECTOR_KEY_CONTROL) |
- BIT(FLOW_DISSECTOR_KEY_BASIC))) {
+ BIT(FLOW_DISSECTOR_KEY_BASIC) |
+ BIT(FLOW_DISSECTOR_KEY_ETH_ADDRS) |
+ BIT(FLOW_DISSECTOR_KEY_VLAN) |
+ BIT(FLOW_DISSECTOR_KEY_CVLAN))) {
NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported flower keys %#x",
dissector->used_keys);
return -EOPNOTSUPP;
}
+ MAP_KEY_AND_MASK(BASIC, basic, n_proto, eth_proto);
if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_BASIC)) {
struct flow_match_basic fm;
flow_rule_match_basic(rule, &fm);
- if (fm.mask->n_proto) {
- NL_SET_ERR_MSG_MOD(extack, "Unsupported eth_proto match");
- return -EOPNOTSUPP;
- }
if (fm.mask->ip_proto) {
NL_SET_ERR_MSG_MOD(extack, "Unsupported ip_proto match");
return -EOPNOTSUPP;
}
}
+ if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_VLAN)) {
+ struct flow_match_vlan fm;
+
+ flow_rule_match_vlan(rule, &fm);
+ if (fm.mask->vlan_id || fm.mask->vlan_priority || fm.mask->vlan_tpid) {
+ match->value.vlan_proto[0] = fm.key->vlan_tpid;
+ match->mask.vlan_proto[0] = fm.mask->vlan_tpid;
+ match->value.vlan_tci[0] = cpu_to_be16(fm.key->vlan_priority << 13 |
+ fm.key->vlan_id);
+ match->mask.vlan_tci[0] = cpu_to_be16(fm.mask->vlan_priority << 13 |
+ fm.mask->vlan_id);
+ }
+ }
+
+ if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_CVLAN)) {
+ struct flow_match_vlan fm;
+
+ flow_rule_match_cvlan(rule, &fm);
+ if (fm.mask->vlan_id || fm.mask->vlan_priority || fm.mask->vlan_tpid) {
+ match->value.vlan_proto[1] = fm.key->vlan_tpid;
+ match->mask.vlan_proto[1] = fm.mask->vlan_tpid;
+ match->value.vlan_tci[1] = cpu_to_be16(fm.key->vlan_priority << 13 |
+ fm.key->vlan_id);
+ match->mask.vlan_tci[1] = cpu_to_be16(fm.mask->vlan_priority << 13 |
+ fm.mask->vlan_id);
+ }
+ }
+
+ if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_ETH_ADDRS)) {
+ struct flow_match_eth_addrs fm;
+
+ flow_rule_match_eth_addrs(rule, &fm);
+ ether_addr_copy(match->value.eth_saddr, fm.key->src);
+ ether_addr_copy(match->value.eth_daddr, fm.key->dst);
+ ether_addr_copy(match->mask.eth_saddr, fm.mask->src);
+ ether_addr_copy(match->mask.eth_daddr, fm.mask->dst);
+ }
+
return 0;
}
diff --git a/drivers/net/ethernet/sfc/tc.h b/drivers/net/ethernet/sfc/tc.h
index 4373c3243e3c..272efbabd6be 100644
--- a/drivers/net/ethernet/sfc/tc.h
+++ b/drivers/net/ethernet/sfc/tc.h
@@ -26,6 +26,10 @@ struct efx_tc_match_fields {
/* L1 */
u32 ingress_port;
u8 recirc_id;
+ /* L2 (inner when encap) */
+ __be16 eth_proto;
+ __be16 vlan_tci[2], vlan_proto[2];
+ u8 eth_saddr[ETH_ALEN], eth_daddr[ETH_ALEN];
};
struct efx_tc_match {
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH net-next 3/5] sfc: add Layer 3 matches to ef100 TC offload
2022-10-24 9:29 [PATCH net-next 0/5] sfc: add basic flower matches to offload edward.cree
2022-10-24 9:29 ` [PATCH net-next 1/5] sfc: check recirc_id match caps before MAE offload edward.cree
2022-10-24 9:29 ` [PATCH net-next 2/5] sfc: add Layer 2 matches to ef100 TC offload edward.cree
@ 2022-10-24 9:29 ` edward.cree
2022-10-24 9:29 ` [PATCH net-next 4/5] sfc: add Layer 3 flag " edward.cree
2022-10-24 9:29 ` [PATCH net-next 5/5] sfc: add Layer 4 " edward.cree
4 siblings, 0 replies; 11+ messages in thread
From: edward.cree @ 2022-10-24 9:29 UTC (permalink / raw)
To: netdev, linux-net-drivers
Cc: davem, kuba, pabeni, edumazet, habetsm.xilinx, Edward Cree
From: Edward Cree <ecree.xilinx@gmail.com>
Support matching on IP protocol, Type of Service, Time To Live, source
and destination addresses, with masking if supported by the hardware.
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
---
drivers/net/ethernet/sfc/mae.c | 39 +++++++++++++++++++++++
drivers/net/ethernet/sfc/mcdi.h | 6 ++++
drivers/net/ethernet/sfc/tc.c | 56 +++++++++++++++++++++++++++------
drivers/net/ethernet/sfc/tc.h | 8 +++++
4 files changed, 100 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/sfc/mae.c b/drivers/net/ethernet/sfc/mae.c
index e119bc61ced7..74de6a907a80 100644
--- a/drivers/net/ethernet/sfc/mae.c
+++ b/drivers/net/ethernet/sfc/mae.c
@@ -291,6 +291,15 @@ int efx_mae_match_check_caps(struct efx_nic *efx,
CHECK(VLAN1_PROTO, vlan_proto[1]);
CHECK(ETH_SADDR, eth_saddr);
CHECK(ETH_DADDR, eth_daddr);
+ CHECK(IP_PROTO, ip_proto);
+ CHECK(IP_TOS, ip_tos);
+ CHECK(IP_TTL, ip_ttl);
+ CHECK(SRC_IP4, src_ip);
+ CHECK(DST_IP4, dst_ip);
+#ifdef CONFIG_IPV6
+ CHECK(SRC_IP6, src_ip6);
+ CHECK(DST_IP6, dst_ip6);
+#endif
CHECK(RECIRC_ID, recirc_id);
return 0;
}
@@ -495,6 +504,36 @@ static int efx_mae_populate_match_criteria(MCDI_DECLARE_STRUCT_PTR(match_crit),
match->value.eth_daddr, ETH_ALEN);
memcpy(MCDI_STRUCT_PTR(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_ETH_DADDR_BE_MASK),
match->mask.eth_daddr, ETH_ALEN);
+ MCDI_STRUCT_SET_BYTE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_IP_PROTO,
+ match->value.ip_proto);
+ MCDI_STRUCT_SET_BYTE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_IP_PROTO_MASK,
+ match->mask.ip_proto);
+ MCDI_STRUCT_SET_BYTE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_IP_TOS,
+ match->value.ip_tos);
+ MCDI_STRUCT_SET_BYTE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_IP_TOS_MASK,
+ match->mask.ip_tos);
+ MCDI_STRUCT_SET_BYTE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_IP_TTL,
+ match->value.ip_ttl);
+ MCDI_STRUCT_SET_BYTE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_IP_TTL_MASK,
+ match->mask.ip_ttl);
+ MCDI_STRUCT_SET_DWORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_SRC_IP4_BE,
+ match->value.src_ip);
+ MCDI_STRUCT_SET_DWORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_SRC_IP4_BE_MASK,
+ match->mask.src_ip);
+ MCDI_STRUCT_SET_DWORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_DST_IP4_BE,
+ match->value.dst_ip);
+ MCDI_STRUCT_SET_DWORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_DST_IP4_BE_MASK,
+ match->mask.dst_ip);
+#ifdef CONFIG_IPV6
+ memcpy(MCDI_STRUCT_PTR(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_SRC_IP6_BE),
+ &match->value.src_ip6, sizeof(struct in6_addr));
+ memcpy(MCDI_STRUCT_PTR(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_SRC_IP6_BE_MASK),
+ &match->mask.src_ip6, sizeof(struct in6_addr));
+ memcpy(MCDI_STRUCT_PTR(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_DST_IP6_BE),
+ &match->value.dst_ip6, sizeof(struct in6_addr));
+ memcpy(MCDI_STRUCT_PTR(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_DST_IP6_BE_MASK),
+ &match->mask.dst_ip6, sizeof(struct in6_addr));
+#endif
return 0;
}
diff --git a/drivers/net/ethernet/sfc/mcdi.h b/drivers/net/ethernet/sfc/mcdi.h
index 883a4db695e2..fbeb58104936 100644
--- a/drivers/net/ethernet/sfc/mcdi.h
+++ b/drivers/net/ethernet/sfc/mcdi.h
@@ -236,6 +236,12 @@ void efx_mcdi_sensor_event(struct efx_nic *efx, efx_qword_t *ev);
EFX_POPULATE_DWORD_1(*_MCDI_STRUCT_DWORD(_buf, _field), EFX_DWORD_0, _value)
#define MCDI_DWORD(_buf, _field) \
EFX_DWORD_FIELD(*_MCDI_DWORD(_buf, _field), EFX_DWORD_0)
+/* Write a 32-bit field defined in the protocol as being big-endian. */
+#define MCDI_STRUCT_SET_DWORD_BE(_buf, _field, _value) do { \
+ BUILD_BUG_ON(_field ## _LEN != 4); \
+ BUILD_BUG_ON(_field ## _OFST & 3); \
+ *(__force __be32 *)MCDI_STRUCT_PTR(_buf, _field) = (_value); \
+ } while (0)
#define MCDI_POPULATE_DWORD_1(_buf, _field, _name1, _value1) \
EFX_POPULATE_DWORD_1(*_MCDI_DWORD(_buf, _field), \
MC_CMD_ ## _name1, _value1)
diff --git a/drivers/net/ethernet/sfc/tc.c b/drivers/net/ethernet/sfc/tc.c
index b469a1263211..d992fafc844e 100644
--- a/drivers/net/ethernet/sfc/tc.c
+++ b/drivers/net/ethernet/sfc/tc.c
@@ -144,11 +144,29 @@ static int efx_tc_flower_parse_match(struct efx_nic *efx,
struct netlink_ext_ack *extack)
{
struct flow_dissector *dissector = rule->match.dissector;
+ unsigned char ipv = 0;
+ /* Owing to internal TC infelicities, the IPV6_ADDRS key might be set
+ * even on IPv4 filters; so rather than relying on dissector->used_keys
+ * we check the addr_type in the CONTROL key. If we don't find it (or
+ * it's masked, which should never happen), we treat both IPV4_ADDRS
+ * and IPV6_ADDRS as absent.
+ */
if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_CONTROL)) {
struct flow_match_control fm;
flow_rule_match_control(rule, &fm);
+ if (IS_ALL_ONES(fm.mask->addr_type))
+ switch (fm.key->addr_type) {
+ case FLOW_DISSECTOR_KEY_IPV4_ADDRS:
+ ipv = 4;
+ break;
+ case FLOW_DISSECTOR_KEY_IPV6_ADDRS:
+ ipv = 6;
+ break;
+ default:
+ break;
+ }
if (fm.mask->flags) {
NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported match on control.flags %#x",
@@ -161,22 +179,28 @@ static int efx_tc_flower_parse_match(struct efx_nic *efx,
BIT(FLOW_DISSECTOR_KEY_BASIC) |
BIT(FLOW_DISSECTOR_KEY_ETH_ADDRS) |
BIT(FLOW_DISSECTOR_KEY_VLAN) |
- BIT(FLOW_DISSECTOR_KEY_CVLAN))) {
+ BIT(FLOW_DISSECTOR_KEY_CVLAN) |
+ BIT(FLOW_DISSECTOR_KEY_IPV4_ADDRS) |
+ BIT(FLOW_DISSECTOR_KEY_IPV6_ADDRS) |
+ BIT(FLOW_DISSECTOR_KEY_IP))) {
NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported flower keys %#x",
dissector->used_keys);
return -EOPNOTSUPP;
}
MAP_KEY_AND_MASK(BASIC, basic, n_proto, eth_proto);
- if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_BASIC)) {
- struct flow_match_basic fm;
-
- flow_rule_match_basic(rule, &fm);
- if (fm.mask->ip_proto) {
- NL_SET_ERR_MSG_MOD(extack, "Unsupported ip_proto match");
- return -EOPNOTSUPP;
+ /* Make sure we're IP if any L3/L4 keys used. */
+ if (!IS_ALL_ONES(match->mask.eth_proto) ||
+ !(match->value.eth_proto == htons(ETH_P_IP) ||
+ match->value.eth_proto == htons(ETH_P_IPV6)))
+ if (dissector->used_keys &
+ (BIT(FLOW_DISSECTOR_KEY_IPV4_ADDRS) |
+ BIT(FLOW_DISSECTOR_KEY_IPV6_ADDRS) |
+ BIT(FLOW_DISSECTOR_KEY_IP))) {
+ NL_SET_ERR_MSG_FMT_MOD(extack, "L3 flower keys %#x require protocol ipv[46]",
+ dissector->used_keys);
+ return -EINVAL;
}
- }
if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_VLAN)) {
struct flow_match_vlan fm;
@@ -216,6 +240,20 @@ static int efx_tc_flower_parse_match(struct efx_nic *efx,
ether_addr_copy(match->mask.eth_daddr, fm.mask->dst);
}
+ MAP_KEY_AND_MASK(BASIC, basic, ip_proto, ip_proto);
+ MAP_KEY_AND_MASK(IP, ip, tos, ip_tos);
+ MAP_KEY_AND_MASK(IP, ip, ttl, ip_ttl);
+ if (ipv == 4) {
+ MAP_KEY_AND_MASK(IPV4_ADDRS, ipv4_addrs, src, src_ip);
+ MAP_KEY_AND_MASK(IPV4_ADDRS, ipv4_addrs, dst, dst_ip);
+ }
+#ifdef CONFIG_IPV6
+ else if (ipv == 6) {
+ MAP_KEY_AND_MASK(IPV6_ADDRS, ipv6_addrs, src, src_ip6);
+ MAP_KEY_AND_MASK(IPV6_ADDRS, ipv6_addrs, dst, dst_ip6);
+ }
+#endif
+
return 0;
}
diff --git a/drivers/net/ethernet/sfc/tc.h b/drivers/net/ethernet/sfc/tc.h
index 272efbabd6be..aebe9c251b2c 100644
--- a/drivers/net/ethernet/sfc/tc.h
+++ b/drivers/net/ethernet/sfc/tc.h
@@ -15,6 +15,8 @@
#include <linux/rhashtable.h>
#include "net_driver.h"
+#define IS_ALL_ONES(v) (!(typeof (v))~(v))
+
struct efx_tc_action_set {
u16 deliver:1;
u32 dest_mport;
@@ -30,6 +32,12 @@ struct efx_tc_match_fields {
__be16 eth_proto;
__be16 vlan_tci[2], vlan_proto[2];
u8 eth_saddr[ETH_ALEN], eth_daddr[ETH_ALEN];
+ /* L3 (when IP) */
+ u8 ip_proto, ip_tos, ip_ttl;
+ __be32 src_ip, dst_ip;
+#ifdef CONFIG_IPV6
+ struct in6_addr src_ip6, dst_ip6;
+#endif
};
struct efx_tc_match {
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH net-next 4/5] sfc: add Layer 3 flag matches to ef100 TC offload
2022-10-24 9:29 [PATCH net-next 0/5] sfc: add basic flower matches to offload edward.cree
` (2 preceding siblings ...)
2022-10-24 9:29 ` [PATCH net-next 3/5] sfc: add Layer 3 " edward.cree
@ 2022-10-24 9:29 ` edward.cree
2022-10-24 9:29 ` [PATCH net-next 5/5] sfc: add Layer 4 " edward.cree
4 siblings, 0 replies; 11+ messages in thread
From: edward.cree @ 2022-10-24 9:29 UTC (permalink / raw)
To: netdev, linux-net-drivers
Cc: davem, kuba, pabeni, edumazet, habetsm.xilinx, Edward Cree
From: Edward Cree <ecree.xilinx@gmail.com>
Support matching on ip_frag and ip_firstfrag.
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
---
drivers/net/ethernet/sfc/mae.c | 26 ++++++++++++++++++++++++++
drivers/net/ethernet/sfc/tc.c | 10 +++++++++-
drivers/net/ethernet/sfc/tc.h | 1 +
3 files changed, 36 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/mae.c b/drivers/net/ethernet/sfc/mae.c
index 74de6a907a80..76b75b3975d5 100644
--- a/drivers/net/ethernet/sfc/mae.c
+++ b/drivers/net/ethernet/sfc/mae.c
@@ -264,6 +264,19 @@ static int efx_mae_match_check_cap_typ(u8 support, enum mask_type typ)
return rc; \
} \
} while (0)
+/* Booleans need special handling */
+#define CHECK_BIT(_mcdi, _field) do { \
+ enum mask_type typ = mask->_field ? MASK_ONES : MASK_ZEROES; \
+ \
+ rc = efx_mae_match_check_cap_typ(supported_fields[MAE_FIELD_ ## _mcdi],\
+ typ); \
+ if (rc) { \
+ NL_SET_ERR_MSG_FMT_MOD(extack, \
+ "No support for %s mask in field %s", \
+ mask_type_name(typ), #_field); \
+ return rc; \
+ } \
+} while (0)
int efx_mae_match_check_caps(struct efx_nic *efx,
const struct efx_tc_match_fields *mask,
@@ -300,9 +313,12 @@ int efx_mae_match_check_caps(struct efx_nic *efx,
CHECK(SRC_IP6, src_ip6);
CHECK(DST_IP6, dst_ip6);
#endif
+ CHECK_BIT(IS_IP_FRAG, ip_frag);
+ CHECK_BIT(IP_FIRST_FRAG, ip_firstfrag);
CHECK(RECIRC_ID, recirc_id);
return 0;
}
+#undef CHECK_BIT
#undef CHECK
static bool efx_mae_asl_id(u32 id)
@@ -472,6 +488,16 @@ static int efx_mae_populate_match_criteria(MCDI_DECLARE_STRUCT_PTR(match_crit),
}
MCDI_STRUCT_SET_DWORD(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_INGRESS_MPORT_SELECTOR_MASK,
match->mask.ingress_port);
+ EFX_POPULATE_DWORD_2(*_MCDI_STRUCT_DWORD(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_FLAGS),
+ MAE_FIELD_MASK_VALUE_PAIRS_V2_IS_IP_FRAG,
+ match->value.ip_frag,
+ MAE_FIELD_MASK_VALUE_PAIRS_V2_IP_FIRST_FRAG,
+ match->value.ip_firstfrag);
+ EFX_POPULATE_DWORD_2(*_MCDI_STRUCT_DWORD(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_FLAGS_MASK),
+ MAE_FIELD_MASK_VALUE_PAIRS_V2_IS_IP_FRAG,
+ match->mask.ip_frag,
+ MAE_FIELD_MASK_VALUE_PAIRS_V2_IP_FIRST_FRAG,
+ match->mask.ip_firstfrag);
MCDI_STRUCT_SET_BYTE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_RECIRC_ID,
match->value.recirc_id);
MCDI_STRUCT_SET_BYTE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_RECIRC_ID_MASK,
diff --git a/drivers/net/ethernet/sfc/tc.c b/drivers/net/ethernet/sfc/tc.c
index d992fafc844e..1a9cc2ad1335 100644
--- a/drivers/net/ethernet/sfc/tc.c
+++ b/drivers/net/ethernet/sfc/tc.c
@@ -168,7 +168,15 @@ static int efx_tc_flower_parse_match(struct efx_nic *efx,
break;
}
- if (fm.mask->flags) {
+ if (fm.mask->flags & FLOW_DIS_IS_FRAGMENT) {
+ match->value.ip_frag = fm.key->flags & FLOW_DIS_IS_FRAGMENT;
+ match->mask.ip_frag = true;
+ }
+ if (fm.mask->flags & FLOW_DIS_FIRST_FRAG) {
+ match->value.ip_firstfrag = fm.key->flags & FLOW_DIS_FIRST_FRAG;
+ match->mask.ip_firstfrag = true;
+ }
+ if (fm.mask->flags & ~(FLOW_DIS_IS_FRAGMENT | FLOW_DIS_FIRST_FRAG)) {
NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported match on control.flags %#x",
fm.mask->flags);
return -EOPNOTSUPP;
diff --git a/drivers/net/ethernet/sfc/tc.h b/drivers/net/ethernet/sfc/tc.h
index aebe9c251b2c..d2b61926657b 100644
--- a/drivers/net/ethernet/sfc/tc.h
+++ b/drivers/net/ethernet/sfc/tc.h
@@ -38,6 +38,7 @@ struct efx_tc_match_fields {
#ifdef CONFIG_IPV6
struct in6_addr src_ip6, dst_ip6;
#endif
+ bool ip_frag, ip_firstfrag;
};
struct efx_tc_match {
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH net-next 5/5] sfc: add Layer 4 matches to ef100 TC offload
2022-10-24 9:29 [PATCH net-next 0/5] sfc: add basic flower matches to offload edward.cree
` (3 preceding siblings ...)
2022-10-24 9:29 ` [PATCH net-next 4/5] sfc: add Layer 3 flag " edward.cree
@ 2022-10-24 9:29 ` edward.cree
4 siblings, 0 replies; 11+ messages in thread
From: edward.cree @ 2022-10-24 9:29 UTC (permalink / raw)
To: netdev, linux-net-drivers
Cc: davem, kuba, pabeni, edumazet, habetsm.xilinx, Edward Cree
From: Edward Cree <ecree.xilinx@gmail.com>
Support matching on UDP/TCP source and destination ports and TCP flags,
with masking if supported by the hardware.
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
---
drivers/net/ethernet/sfc/mae.c | 15 +++++++++++++++
drivers/net/ethernet/sfc/tc.c | 21 +++++++++++++++++++--
drivers/net/ethernet/sfc/tc.h | 3 +++
3 files changed, 37 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/sfc/mae.c b/drivers/net/ethernet/sfc/mae.c
index 76b75b3975d5..19b73cef5b30 100644
--- a/drivers/net/ethernet/sfc/mae.c
+++ b/drivers/net/ethernet/sfc/mae.c
@@ -313,6 +313,9 @@ int efx_mae_match_check_caps(struct efx_nic *efx,
CHECK(SRC_IP6, src_ip6);
CHECK(DST_IP6, dst_ip6);
#endif
+ CHECK(L4_SPORT, l4_sport);
+ CHECK(L4_DPORT, l4_dport);
+ CHECK(TCP_FLAGS, tcp_flags);
CHECK_BIT(IS_IP_FRAG, ip_frag);
CHECK_BIT(IP_FIRST_FRAG, ip_firstfrag);
CHECK(RECIRC_ID, recirc_id);
@@ -560,6 +563,18 @@ static int efx_mae_populate_match_criteria(MCDI_DECLARE_STRUCT_PTR(match_crit),
memcpy(MCDI_STRUCT_PTR(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_DST_IP6_BE_MASK),
&match->mask.dst_ip6, sizeof(struct in6_addr));
#endif
+ MCDI_STRUCT_SET_WORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_L4_SPORT_BE,
+ match->value.l4_sport);
+ MCDI_STRUCT_SET_WORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_L4_SPORT_BE_MASK,
+ match->mask.l4_sport);
+ MCDI_STRUCT_SET_WORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_L4_DPORT_BE,
+ match->value.l4_dport);
+ MCDI_STRUCT_SET_WORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_L4_DPORT_BE_MASK,
+ match->mask.l4_dport);
+ MCDI_STRUCT_SET_WORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_TCP_FLAGS_BE,
+ match->value.tcp_flags);
+ MCDI_STRUCT_SET_WORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_TCP_FLAGS_BE_MASK,
+ match->mask.tcp_flags);
return 0;
}
diff --git a/drivers/net/ethernet/sfc/tc.c b/drivers/net/ethernet/sfc/tc.c
index 1a9cc2ad1335..17e1a3447554 100644
--- a/drivers/net/ethernet/sfc/tc.c
+++ b/drivers/net/ethernet/sfc/tc.c
@@ -190,6 +190,8 @@ static int efx_tc_flower_parse_match(struct efx_nic *efx,
BIT(FLOW_DISSECTOR_KEY_CVLAN) |
BIT(FLOW_DISSECTOR_KEY_IPV4_ADDRS) |
BIT(FLOW_DISSECTOR_KEY_IPV6_ADDRS) |
+ BIT(FLOW_DISSECTOR_KEY_PORTS) |
+ BIT(FLOW_DISSECTOR_KEY_TCP) |
BIT(FLOW_DISSECTOR_KEY_IP))) {
NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported flower keys %#x",
dissector->used_keys);
@@ -204,8 +206,10 @@ static int efx_tc_flower_parse_match(struct efx_nic *efx,
if (dissector->used_keys &
(BIT(FLOW_DISSECTOR_KEY_IPV4_ADDRS) |
BIT(FLOW_DISSECTOR_KEY_IPV6_ADDRS) |
- BIT(FLOW_DISSECTOR_KEY_IP))) {
- NL_SET_ERR_MSG_FMT_MOD(extack, "L3 flower keys %#x require protocol ipv[46]",
+ BIT(FLOW_DISSECTOR_KEY_PORTS) |
+ BIT(FLOW_DISSECTOR_KEY_IP) |
+ BIT(FLOW_DISSECTOR_KEY_TCP))) {
+ NL_SET_ERR_MSG_FMT_MOD(extack, "L3/L4 flower keys %#x require protocol ipv[46]",
dissector->used_keys);
return -EINVAL;
}
@@ -249,6 +253,16 @@ static int efx_tc_flower_parse_match(struct efx_nic *efx,
}
MAP_KEY_AND_MASK(BASIC, basic, ip_proto, ip_proto);
+ /* Make sure we're TCP/UDP if any L4 keys used. */
+ if ((match->value.ip_proto != IPPROTO_UDP &&
+ match->value.ip_proto != IPPROTO_TCP) || !IS_ALL_ONES(match->mask.ip_proto))
+ if (dissector->used_keys &
+ (BIT(FLOW_DISSECTOR_KEY_PORTS) |
+ BIT(FLOW_DISSECTOR_KEY_TCP))) {
+ NL_SET_ERR_MSG_FMT_MOD(extack, "L4 flower keys %#x require ipproto udp or tcp",
+ dissector->used_keys);
+ return -EINVAL;
+ }
MAP_KEY_AND_MASK(IP, ip, tos, ip_tos);
MAP_KEY_AND_MASK(IP, ip, ttl, ip_ttl);
if (ipv == 4) {
@@ -261,6 +275,9 @@ static int efx_tc_flower_parse_match(struct efx_nic *efx,
MAP_KEY_AND_MASK(IPV6_ADDRS, ipv6_addrs, dst, dst_ip6);
}
#endif
+ MAP_KEY_AND_MASK(PORTS, ports, src, l4_sport);
+ MAP_KEY_AND_MASK(PORTS, ports, dst, l4_dport);
+ MAP_KEY_AND_MASK(TCP, tcp, flags, tcp_flags);
return 0;
}
diff --git a/drivers/net/ethernet/sfc/tc.h b/drivers/net/ethernet/sfc/tc.h
index d2b61926657b..4240c375a8e6 100644
--- a/drivers/net/ethernet/sfc/tc.h
+++ b/drivers/net/ethernet/sfc/tc.h
@@ -39,6 +39,9 @@ struct efx_tc_match_fields {
struct in6_addr src_ip6, dst_ip6;
#endif
bool ip_frag, ip_firstfrag;
+ /* L4 */
+ __be16 l4_sport, l4_dport; /* Ports (UDP, TCP) */
+ __be16 tcp_flags;
};
struct efx_tc_match {
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH net-next 1/5] sfc: check recirc_id match caps before MAE offload
2022-10-24 9:29 ` [PATCH net-next 1/5] sfc: check recirc_id match caps before MAE offload edward.cree
@ 2022-10-26 2:40 ` Jakub Kicinski
2022-11-01 13:30 ` Edward Cree
0 siblings, 1 reply; 11+ messages in thread
From: Jakub Kicinski @ 2022-10-26 2:40 UTC (permalink / raw)
To: edward.cree
Cc: netdev, linux-net-drivers, davem, pabeni, edumazet,
habetsm.xilinx, Edward Cree
On Mon, 24 Oct 2022 10:29:21 +0100 edward.cree@amd.com wrote:
> From: Edward Cree <ecree.xilinx@gmail.com>
>
> Offloaded TC rules always match on recirc_id in the MAE, so we should
> check that the MAE reported support for this match before attempting
> to insert the rule.
>
> Fixes: d902e1a737d4 ("sfc: bare bones TC offload on EF100")
This commit made it to net, needs to go separately there.
> +/* Validate field mask against hardware capabilities. May return from caller */
> +#define CHECK(_mcdi, _field) do { \
> + enum mask_type typ = classify_mask((const u8 *)&mask->_field, \
> + sizeof(mask->_field)); \
> + \
> + rc = efx_mae_match_check_cap_typ(supported_fields[MAE_FIELD_ ## _mcdi],\
> + typ); \
> + if (rc) { \
> + NL_SET_ERR_MSG_FMT_MOD(extack, \
> + "No support for %s mask in field %s", \
> + mask_type_name(typ), #_field); \
> + return rc; \
We still don't allow flow control to hide inside macros.
You add the checks next to each other (looking at the next patch)
so you can return rc from the macro and easily combine the checks
into one large if statement. Result - close to ~1 line per check.
> + } \
> +} while (0)
> +
> int efx_mae_match_check_caps(struct efx_nic *efx,
> const struct efx_tc_match_fields *mask,
> struct netlink_ext_ack *extack)
> @@ -269,6 +284,7 @@ int efx_mae_match_check_caps(struct efx_nic *efx,
> mask_type_name(ingress_port_mask_type));
> return rc;
> }
> + CHECK(RECIRC_ID, recirc_id);
> return 0;
I think the #undef leaked into the next patch.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH net-next 1/5] sfc: check recirc_id match caps before MAE offload
2022-10-26 2:40 ` Jakub Kicinski
@ 2022-11-01 13:30 ` Edward Cree
2022-11-01 15:21 ` Jakub Kicinski
0 siblings, 1 reply; 11+ messages in thread
From: Edward Cree @ 2022-11-01 13:30 UTC (permalink / raw)
To: Jakub Kicinski, edward.cree
Cc: netdev, linux-net-drivers, davem, pabeni, edumazet,
habetsm.xilinx
On 26/10/2022 03:40, Jakub Kicinski wrote:
> On Mon, 24 Oct 2022 10:29:21 +0100 edward.cree@amd.com wrote:
>> From: Edward Cree <ecree.xilinx@gmail.com>
>>
>> Offloaded TC rules always match on recirc_id in the MAE, so we should
>> check that the MAE reported support for this match before attempting
>> to insert the rule.
>>
>> Fixes: d902e1a737d4 ("sfc: bare bones TC offload on EF100")
>
> This commit made it to net, needs to go separately there.
Hmm I might just drop the fixes tag; the cited commit isn't really
broken, just suboptimal.
> We still don't allow flow control to hide inside macros.
>
> You add the checks next to each other (looking at the next patch)
> so you can return rc from the macro and easily combine the checks
> into one large if statement. Result - close to ~1 line per check.
Ah yeah, I forgot statement-like macros can still return values.
Will fix, thanks.
-ed
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH net-next 1/5] sfc: check recirc_id match caps before MAE offload
2022-11-01 13:30 ` Edward Cree
@ 2022-11-01 15:21 ` Jakub Kicinski
2022-11-01 15:41 ` Edward Cree
0 siblings, 1 reply; 11+ messages in thread
From: Jakub Kicinski @ 2022-11-01 15:21 UTC (permalink / raw)
To: Edward Cree
Cc: edward.cree, netdev, linux-net-drivers, davem, pabeni, edumazet,
habetsm.xilinx
On Tue, 1 Nov 2022 13:30:10 +0000 Edward Cree wrote:
> > This commit made it to net, needs to go separately there.
>
> Hmm I might just drop the fixes tag; the cited commit isn't really
> broken, just suboptimal.
Can you describe the current behavior is? Isn't the driver accepting
rules it can't correctly offload?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH net-next 1/5] sfc: check recirc_id match caps before MAE offload
2022-11-01 15:21 ` Jakub Kicinski
@ 2022-11-01 15:41 ` Edward Cree
2022-11-01 15:50 ` Jakub Kicinski
0 siblings, 1 reply; 11+ messages in thread
From: Edward Cree @ 2022-11-01 15:41 UTC (permalink / raw)
To: Jakub Kicinski
Cc: edward.cree, netdev, linux-net-drivers, davem, pabeni, edumazet,
habetsm.xilinx
On 01/11/2022 15:21, Jakub Kicinski wrote:
> On Tue, 1 Nov 2022 13:30:10 +0000 Edward Cree wrote:
>>> This commit made it to net, needs to go separately there.
>>
>> Hmm I might just drop the fixes tag; the cited commit isn't really
>> broken, just suboptimal.
>
> Can you describe the current behavior is? Isn't the driver accepting
> rules it can't correctly offload?
The rule will pass the checks here, but then when we make the MCDI call
to install it in hardware, MC_CMD_MAE_ACTION_RULE_INSERT will evoke an
error response from the firmware, so the TC_SETUP_CLSFLOWER callback
will ultimately return an error to the kernel as it should.
The advantage of having these checks in the driver is that we get a
useful error message rather than just "Failed to insert rule in hw",
and also save the round trip across the PCIe bus to firmware.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH net-next 1/5] sfc: check recirc_id match caps before MAE offload
2022-11-01 15:41 ` Edward Cree
@ 2022-11-01 15:50 ` Jakub Kicinski
0 siblings, 0 replies; 11+ messages in thread
From: Jakub Kicinski @ 2022-11-01 15:50 UTC (permalink / raw)
To: Edward Cree
Cc: edward.cree, netdev, linux-net-drivers, davem, pabeni, edumazet,
habetsm.xilinx
On Tue, 1 Nov 2022 15:41:13 +0000 Edward Cree wrote:
> > Can you describe the current behavior is? Isn't the driver accepting
> > rules it can't correctly offload?
>
> The rule will pass the checks here, but then when we make the MCDI call
> to install it in hardware, MC_CMD_MAE_ACTION_RULE_INSERT will evoke an
> error response from the firmware, so the TC_SETUP_CLSFLOWER callback
> will ultimately return an error to the kernel as it should.
> The advantage of having these checks in the driver is that we get a
> useful error message rather than just "Failed to insert rule in hw",
> and also save the round trip across the PCIe bus to firmware.
I see, net-next sounds good then. Do put this info into the commit
message, please.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-11-01 15:50 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-24 9:29 [PATCH net-next 0/5] sfc: add basic flower matches to offload edward.cree
2022-10-24 9:29 ` [PATCH net-next 1/5] sfc: check recirc_id match caps before MAE offload edward.cree
2022-10-26 2:40 ` Jakub Kicinski
2022-11-01 13:30 ` Edward Cree
2022-11-01 15:21 ` Jakub Kicinski
2022-11-01 15:41 ` Edward Cree
2022-11-01 15:50 ` Jakub Kicinski
2022-10-24 9:29 ` [PATCH net-next 2/5] sfc: add Layer 2 matches to ef100 TC offload edward.cree
2022-10-24 9:29 ` [PATCH net-next 3/5] sfc: add Layer 3 " edward.cree
2022-10-24 9:29 ` [PATCH net-next 4/5] sfc: add Layer 3 flag " edward.cree
2022-10-24 9:29 ` [PATCH net-next 5/5] sfc: add Layer 4 " edward.cree
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).