From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"netdev@kapio-technology.com" <netdev@kapio-technology.com>,
"mlxsw@nvidia.com" <mlxsw@nvidia.com>
Subject: Re: [PATCH net-next v2 1/2] rocker: Avoid unnecessary scheduling of work item
Date: Tue, 1 Nov 2022 16:21:07 +0000 [thread overview]
Message-ID: <20221101162106.xaikqelommua5xib@skbuf> (raw)
In-Reply-To: <20221101123936.1900453-2-idosch@nvidia.com> <20221101123936.1900453-2-idosch@nvidia.com>
On Tue, Nov 01, 2022 at 02:39:35PM +0200, Ido Schimmel wrote:
> The work item function ofdpa_port_fdb_learn_work() does not do anything
> when 'OFDPA_OP_FLAG_LEARNED' is not set in the work item's flags.
>
> Therefore, do not allocate and do not schedule the work item when the
> flag is not set.
>
> Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
next prev parent reply other threads:[~2022-11-01 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 12:39 [PATCH net-next v2 0/2] rocker: Two small changes Ido Schimmel
2022-11-01 12:39 ` [PATCH net-next v2 1/2] rocker: Avoid unnecessary scheduling of work item Ido Schimmel
2022-11-01 16:21 ` Vladimir Oltean [this message]
2022-11-01 12:39 ` [PATCH net-next v2 2/2] rocker: Explicitly mark learned FDB entries as offloaded Ido Schimmel
2022-11-01 16:21 ` Vladimir Oltean
2022-11-03 3:50 ` [PATCH net-next v2 0/2] rocker: Two small changes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221101162106.xaikqelommua5xib@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@kapio-technology.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox