From: Nick Child <nnac123@linux.ibm.com>
To: netdev@vger.kernel.org
Cc: nick.child@ibm.com, bjking1@linux.ibm.com, ricklind@us.ibm.com,
dave.taht@gmail.com, Nick Child <nnac123@linux.ibm.com>
Subject: [PATCH net] ibmveth: Reduce maximum tx queues to 8
Date: Wed, 2 Nov 2022 10:30:40 -0500 [thread overview]
Message-ID: <20221102153040.149244-1-nnac123@linux.ibm.com> (raw)
Previously, the maximum number of transmit queues
allowed was 16. Due to resource concerns, limit
to 8 queues instead.
Since the driver is virtualized away from the
physical NIC, the purpose of multiple queues is
purely to allow for parallel calls to the
hypervisor. Therefore, there is no noticeable
effect on performance by reducing queue count to 8.
Reported-by: Reported-by: Dave Taht <dave.taht@gmail.com>
Signed-off-by: Nick Child <nnac123@linux.ibm.com>
---
Relevant links:
- Introduce multiple tx queues (accepted in v6.1):
https://lore.kernel.org/netdev/20220928214350.29795-2-nnac123@linux.ibm.com/
- Resource concerns with 16 queues:
https://lore.kernel.org/netdev/CAA93jw5reJmaOvt9vw15C1fo1AN7q5jVKzUocbAoNDC-cpi=KQ@mail.gmail.com/
drivers/net/ethernet/ibm/ibmveth.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmveth.h b/drivers/net/ethernet/ibm/ibmveth.h
index 4f8357187292..6b5faf1feb0b 100644
--- a/drivers/net/ethernet/ibm/ibmveth.h
+++ b/drivers/net/ethernet/ibm/ibmveth.h
@@ -99,7 +99,7 @@ static inline long h_illan_attributes(unsigned long unit_address,
#define IBMVETH_FILT_LIST_SIZE 4096
#define IBMVETH_MAX_BUF_SIZE (1024 * 128)
#define IBMVETH_MAX_TX_BUF_SIZE (1024 * 64)
-#define IBMVETH_MAX_QUEUES 16U
+#define IBMVETH_MAX_QUEUES 8U
static int pool_size[] = { 512, 1024 * 2, 1024 * 16, 1024 * 32, 1024 * 64 };
static int pool_count[] = { 256, 512, 256, 256, 256 };
--
2.31.1
next reply other threads:[~2022-11-02 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 15:30 Nick Child [this message]
2022-11-06 19:00 ` [PATCH net] ibmveth: Reduce maximum tx queues to 8 Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221102153040.149244-1-nnac123@linux.ibm.com \
--to=nnac123@linux.ibm.com \
--cc=bjking1@linux.ibm.com \
--cc=dave.taht@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nick.child@ibm.com \
--cc=ricklind@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).