From: Jakub Kicinski <kuba@kernel.org>
To: Cai Huoqing <cai.huoqing@linux.dev>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Zhengchao Shao <shaozhengchao@huawei.com>,
Alexei Starovoitov <ast@kernel.org>,
SeongJae Park <sj@kernel.org>, Peter Chen <peter.chen@kernel.org>,
Bin Chen <bin.chen@corigine.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable
Date: Wed, 2 Nov 2022 20:36:40 -0700 [thread overview]
Message-ID: <20221102203640.1bda5d74@kernel.org> (raw)
In-Reply-To: <20221101060358.7837-1-cai.huoqing@linux.dev>
On Tue, 1 Nov 2022 14:03:38 +0800 Cai Huoqing wrote:
> The print cmd code is in hex, so using hex cmd code intead of
> decimal is easy to check the value with print info.
You're still removing empty lines making this patch much harder
to review. Once again - it should be a pure conversion to dec -> hex.
Don't make any other changes.
next prev parent reply other threads:[~2022-11-03 3:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 6:03 [PATCH net-next v2 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable Cai Huoqing
2022-11-01 6:03 ` [PATCH net-next v2 2/2] net: hinic: Add control command support for VF PMD driver in DPDK Cai Huoqing
2022-11-01 10:46 ` Jani Nikula
2022-11-01 12:17 ` Cai Huoqing
2022-11-01 12:37 ` Jani Nikula
2022-11-01 15:37 ` Jakub Kicinski
2022-11-01 16:06 ` Jani Nikula
2022-11-03 3:36 ` Jakub Kicinski [this message]
2022-11-04 3:53 ` [PATCH net-next v2 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable Cai Huoqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221102203640.1bda5d74@kernel.org \
--to=kuba@kernel.org \
--cc=ast@kernel.org \
--cc=bin.chen@corigine.com \
--cc=cai.huoqing@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peter.chen@kernel.org \
--cc=shaozhengchao@huawei.com \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).