From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
jiri@resnulli.us, razor@blackwall.org, nicolas.dichtel@6wind.com,
gnault@redhat.com, jacob.e.keller@intel.com, fw@strlen.de,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v2 00/13] genetlink: support per op type policies
Date: Wed, 2 Nov 2022 14:33:25 -0700 [thread overview]
Message-ID: <20221102213338.194672-1-kuba@kernel.org> (raw)
While writing new genetlink families I was increasingly annoyed by the fact
that we don't support different policies for do and dump callbacks.
This makes it hard to do proper input validation for dumps which usually
have a lot more narrow range of accepted attributes.
There is also a minor inconvenience of not supporting different per_doit
and post_doit callbacks per op.
This series addresses those problems by introducing another op format.
v2:
- wait for net changes to propagate
- restore the missing comment in patch 1
- drop extra space in patch 3
- improve commit message in patch 4
v1: https://lore.kernel.org/all/20221018230728.1039524-1-kuba@kernel.org/
Jakub Kicinski (13):
genetlink: refactor the cmd <> policy mapping dump
genetlink: move the private fields in struct genl_family
genetlink: introduce split op representation
genetlink: load policy based on validation flags
genetlink: check for callback type at op load time
genetlink: add policies for both doit and dumpit in
ctrl_dumppolicy_start()
genetlink: support split policies in ctrl_dumppolicy_put_op()
genetlink: inline genl_get_cmd()
genetlink: add iterator for walking family ops
genetlink: use iterator in the op to policy map dumping
genetlink: inline old iteration helpers
genetlink: allow families to use split ops directly
genetlink: convert control family to split ops
include/net/genetlink.h | 76 +++++-
net/batman-adv/netlink.c | 6 +-
net/core/devlink.c | 4 +-
net/core/drop_monitor.c | 4 +-
net/ieee802154/nl802154.c | 6 +-
net/netlink/genetlink.c | 473 ++++++++++++++++++++++++++++----------
net/wireless/nl80211.c | 6 +-
7 files changed, 433 insertions(+), 142 deletions(-)
--
2.38.1
next reply other threads:[~2022-11-02 21:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 21:33 Jakub Kicinski [this message]
2022-11-02 21:33 ` [PATCH net-next v2 01/13] genetlink: refactor the cmd <> policy mapping dump Jakub Kicinski
2022-11-02 23:52 ` Jacob Keller
2022-11-03 1:52 ` Jakub Kicinski
2022-11-03 3:06 ` Keller, Jacob E
2022-11-02 21:33 ` [PATCH net-next v2 02/13] genetlink: move the private fields in struct genl_family Jakub Kicinski
2022-11-02 21:33 ` [PATCH net-next v2 03/13] genetlink: introduce split op representation Jakub Kicinski
2022-11-02 21:33 ` [PATCH net-next v2 04/13] genetlink: load policy based on validation flags Jakub Kicinski
2022-11-02 21:33 ` [PATCH net-next v2 05/13] genetlink: check for callback type at op load time Jakub Kicinski
2022-11-02 21:33 ` [PATCH net-next v2 06/13] genetlink: add policies for both doit and dumpit in ctrl_dumppolicy_start() Jakub Kicinski
2022-11-03 17:38 ` Jacob Keller
2022-11-02 21:33 ` [PATCH net-next v2 07/13] genetlink: support split policies in ctrl_dumppolicy_put_op() Jakub Kicinski
2022-11-02 21:33 ` [PATCH net-next v2 08/13] genetlink: inline genl_get_cmd() Jakub Kicinski
2022-11-03 17:04 ` Jacob Keller
2022-11-02 21:33 ` [PATCH net-next v2 09/13] genetlink: add iterator for walking family ops Jakub Kicinski
2022-11-02 21:33 ` [PATCH net-next v2 10/13] genetlink: use iterator in the op to policy map dumping Jakub Kicinski
2022-11-02 21:33 ` [PATCH net-next v2 11/13] genetlink: inline old iteration helpers Jakub Kicinski
2022-11-02 21:33 ` [PATCH net-next v2 12/13] genetlink: allow families to use split ops directly Jakub Kicinski
2022-11-04 22:10 ` Nicolas Dichtel
2022-11-04 22:19 ` Jakub Kicinski
2022-11-04 22:28 ` Nicolas Dichtel
2022-11-02 21:33 ` [PATCH net-next v2 13/13] genetlink: convert control family to split ops Jakub Kicinski
2022-11-03 17:09 ` [PATCH net-next v2 00/13] genetlink: support per op type policies Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221102213338.194672-1-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=gnault@redhat.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).