netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	jiri@resnulli.us, razor@blackwall.org, nicolas.dichtel@6wind.com,
	gnault@redhat.com, jacob.e.keller@intel.com, fw@strlen.de,
	Jakub Kicinski <kuba@kernel.org>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: [PATCH net-next v2 02/13] genetlink: move the private fields in struct genl_family
Date: Wed,  2 Nov 2022 14:33:27 -0700	[thread overview]
Message-ID: <20221102213338.194672-3-kuba@kernel.org> (raw)
In-Reply-To: <20221102213338.194672-1-kuba@kernel.org>

Move the private fields down to form a "private section".
Use the kdoc "private:" label comment thing to hide them
from the main kdoc comment.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
---
I did this cleanup to add more private fields but ended up
not needing them. Still I think the commit makes sense?
---
 include/net/genetlink.h | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/include/net/genetlink.h b/include/net/genetlink.h
index 9f97f73615b6..81180fc6526a 100644
--- a/include/net/genetlink.h
+++ b/include/net/genetlink.h
@@ -23,7 +23,6 @@ struct genl_info;
 
 /**
  * struct genl_family - generic netlink family
- * @id: protocol family identifier (private)
  * @hdrsize: length of user specific header in bytes
  * @name: name of family
  * @version: protocol version
@@ -43,8 +42,6 @@ struct genl_info;
  * @resv_start_op: first operation for which reserved fields of the header
  *	can be validated and policies are required (see below);
  *	new families should leave this field at zero
- * @mcgrp_offset: starting number of multicast group IDs in this family
- *	(private)
  * @ops: the operations supported by this family
  * @n_ops: number of operations supported by this family
  * @small_ops: the small-struct operations supported by this family
@@ -58,12 +55,10 @@ struct genl_info;
  * if policy is not provided core will reject all TLV attributes.
  */
 struct genl_family {
-	int			id;		/* private */
 	unsigned int		hdrsize;
 	char			name[GENL_NAMSIZ];
 	unsigned int		version;
 	unsigned int		maxattr;
-	unsigned int		mcgrp_offset;	/* private */
 	u8			netnsok:1;
 	u8			parallel_ops:1;
 	u8			n_ops;
@@ -81,6 +76,12 @@ struct genl_family {
 	const struct genl_small_ops *small_ops;
 	const struct genl_multicast_group *mcgrps;
 	struct module		*module;
+
+/* private: internal use only */
+	/* protocol family identifier */
+	int			id;
+	/* starting number of multicast group IDs in this family */
+	unsigned int		mcgrp_offset;
 };
 
 /**
-- 
2.38.1


  parent reply	other threads:[~2022-11-02 21:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 21:33 [PATCH net-next v2 00/13] genetlink: support per op type policies Jakub Kicinski
2022-11-02 21:33 ` [PATCH net-next v2 01/13] genetlink: refactor the cmd <> policy mapping dump Jakub Kicinski
2022-11-02 23:52   ` Jacob Keller
2022-11-03  1:52     ` Jakub Kicinski
2022-11-03  3:06       ` Keller, Jacob E
2022-11-02 21:33 ` Jakub Kicinski [this message]
2022-11-02 21:33 ` [PATCH net-next v2 03/13] genetlink: introduce split op representation Jakub Kicinski
2022-11-02 21:33 ` [PATCH net-next v2 04/13] genetlink: load policy based on validation flags Jakub Kicinski
2022-11-02 21:33 ` [PATCH net-next v2 05/13] genetlink: check for callback type at op load time Jakub Kicinski
2022-11-02 21:33 ` [PATCH net-next v2 06/13] genetlink: add policies for both doit and dumpit in ctrl_dumppolicy_start() Jakub Kicinski
2022-11-03 17:38   ` Jacob Keller
2022-11-02 21:33 ` [PATCH net-next v2 07/13] genetlink: support split policies in ctrl_dumppolicy_put_op() Jakub Kicinski
2022-11-02 21:33 ` [PATCH net-next v2 08/13] genetlink: inline genl_get_cmd() Jakub Kicinski
2022-11-03 17:04   ` Jacob Keller
2022-11-02 21:33 ` [PATCH net-next v2 09/13] genetlink: add iterator for walking family ops Jakub Kicinski
2022-11-02 21:33 ` [PATCH net-next v2 10/13] genetlink: use iterator in the op to policy map dumping Jakub Kicinski
2022-11-02 21:33 ` [PATCH net-next v2 11/13] genetlink: inline old iteration helpers Jakub Kicinski
2022-11-02 21:33 ` [PATCH net-next v2 12/13] genetlink: allow families to use split ops directly Jakub Kicinski
2022-11-04 22:10   ` Nicolas Dichtel
2022-11-04 22:19     ` Jakub Kicinski
2022-11-04 22:28       ` Nicolas Dichtel
2022-11-02 21:33 ` [PATCH net-next v2 13/13] genetlink: convert control family to split ops Jakub Kicinski
2022-11-03 17:09 ` [PATCH net-next v2 00/13] genetlink: support per op type policies Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221102213338.194672-3-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=gnault@redhat.com \
    --cc=jacob.e.keller@intel.com \
    --cc=jiri@resnulli.us \
    --cc=johannes@sipsolutions.net \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).