From: Jakub Kicinski <kuba@kernel.org>
To: zhang.songyi@zte.com.cn
Cc: Shannon Nelson <shnelson@amd.com>,
snelson@pensando.io, drivers@pensando.io, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, brett@pensando.io,
mohamed@pensando.io, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, jiang.xuexin@zte.com.cn,
xue.zhihong@zte.com.cn
Subject: Re: [PATCH linux-next] ionic: remove redundant ret variable
Date: Thu, 3 Nov 2022 20:50:32 -0700 [thread overview]
Message-ID: <20221103205032.4fe32f58@kernel.org> (raw)
In-Reply-To: <17ef4641-7cb3-fea8-4b1a-30b90c1719a1@amd.com>
On Wed, 2 Nov 2022 09:07:34 -0700 Shannon Nelson wrote:
> On 11/2/22 6:48 AM, zhang.songyi@zte.com.cn wrote:
> > From 06579895d9e3f6441fa30d52e3b585b2015c7e2e Mon Sep 17 00:00:00 2001
> > From: zhang songyi <zhang.songyi@zte.com.cn>
> > Date: Wed, 2 Nov 2022 20:57:40 +0800
> > Subject: [PATCH linux-next] ionic: remove redundant ret variable
> >
> > Return value from ionic_set_features() directly instead of taking this in
> > another redundant variable.
> >
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
>
> Acked-by: Shannon Nelson <snelson@pensando.io>
>
> ... although these changes usually go through the net or net-next trees.
net-next in this case, but it doesn't apply, please rebase and repost.
prev parent reply other threads:[~2022-11-04 3:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 13:48 [PATCH linux-next] ionic: remove redundant ret variable zhang.songyi
2022-11-02 16:07 ` Shannon Nelson
2022-11-04 3:50 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221103205032.4fe32f58@kernel.org \
--to=kuba@kernel.org \
--cc=brett@pensando.io \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=edumazet@google.com \
--cc=jiang.xuexin@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=mohamed@pensando.io \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shnelson@amd.com \
--cc=snelson@pensando.io \
--cc=xue.zhihong@zte.com.cn \
--cc=zhang.songyi@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).