From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77C9AC4332F for ; Fri, 4 Nov 2022 03:50:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229674AbiKDDuo (ORCPT ); Thu, 3 Nov 2022 23:50:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbiKDDui (ORCPT ); Thu, 3 Nov 2022 23:50:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F225D13DE2; Thu, 3 Nov 2022 20:50:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 872A8B82B60; Fri, 4 Nov 2022 03:50:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B019FC433C1; Fri, 4 Nov 2022 03:50:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667533834; bh=FyzXENV7WIn5Uu5Adesc2hv84yU5ZUifhCcXpjv7AxY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rRUafkPmNamHHAzrr9ZpHYSQa0E9OV1llpGUVJYgC5gMPCmEqmkIznEaAC4rCxtHl d43Curjpua5SgxtS2MEc1dj4orWiAWSucQU8WJ2wM8agLFcHrLm2cBVLP1DBch7vtQ 36l7OJnobeVu7AhEGByHzS3i+tb2hBxzPBz0GiWQdCVZQioqOZfWqLmNOEDcrE83nO rhs3gZslZGNFaOgSBPf/KN/0HGM2Zhw7Qpdaws8AJrLf3X5B+Vgz5EogM1DJBF/QO/ nIHTZAikqPzVVNJFpDRWSKgtCry1WDnCYERwx1HkATQHOUmAMATsRtGY8ZofMddYCO DoAcyqlyzTXMQ== Date: Thu, 3 Nov 2022 20:50:32 -0700 From: Jakub Kicinski To: zhang.songyi@zte.com.cn Cc: Shannon Nelson , snelson@pensando.io, drivers@pensando.io, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, brett@pensando.io, mohamed@pensando.io, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jiang.xuexin@zte.com.cn, xue.zhihong@zte.com.cn Subject: Re: [PATCH linux-next] ionic: remove redundant ret variable Message-ID: <20221103205032.4fe32f58@kernel.org> In-Reply-To: <17ef4641-7cb3-fea8-4b1a-30b90c1719a1@amd.com> References: <202211022148203360503@zte.com.cn> <17ef4641-7cb3-fea8-4b1a-30b90c1719a1@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 2 Nov 2022 09:07:34 -0700 Shannon Nelson wrote: > On 11/2/22 6:48 AM, zhang.songyi@zte.com.cn wrote: > > From 06579895d9e3f6441fa30d52e3b585b2015c7e2e Mon Sep 17 00:00:00 2001 > > From: zhang songyi > > Date: Wed, 2 Nov 2022 20:57:40 +0800 > > Subject: [PATCH linux-next] ionic: remove redundant ret variable > > > > Return value from ionic_set_features() directly instead of taking this in > > another redundant variable. > > > > Reported-by: Zeal Robot > > Signed-off-by: zhang songyi > > Acked-by: Shannon Nelson > > ... although these changes usually go through the net or net-next trees. net-next in this case, but it doesn't apply, please rebase and repost.