From: Jakub Kicinski <kuba@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<sgoutham@marvell.com>
Subject: Re: [net PATCH] octeontx2-pf: Fix SQE threshold checking
Date: Thu, 3 Nov 2022 20:54:52 -0700 [thread overview]
Message-ID: <20221103205452.6d58cbf9@kernel.org> (raw)
In-Reply-To: <20221102033240.1923677-1-rkannoth@marvell.com>
On Wed, 2 Nov 2022 09:02:40 +0530 Ratheesh Kannoth wrote:
> @@ -1599,7 +1600,6 @@ int otx2_nix_config_bp(struct otx2_nic *pfvf, bool enable)
> req->bpid_per_chan = 0;
> #endif
>
> -
> return otx2_sync_mbox_msg(&pfvf->mbox);
> }
> EXPORT_SYMBOL(otx2_nix_config_bp);
The patch looks good but we can't have spurious cleanups in fixes,
please repost without this chunk.
prev parent reply other threads:[~2022-11-04 3:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 3:32 [net PATCH] octeontx2-pf: Fix SQE threshold checking Ratheesh Kannoth
2022-11-04 3:54 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221103205452.6d58cbf9@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).