* [PATCH net-next v1.2] net: phy: fix yt8521 duplicated argument to & or |
@ 2022-11-03 6:14 Frank
2022-11-04 4:03 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Frank @ 2022-11-03 6:14 UTC (permalink / raw)
To: Peter Geis, Andrew Lunn, Heiner Kallweit, Russell King,
David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: yinghong.zhang, fei.zhang, hua.sun, netdev, linux-kernel, Frank,
kernel test robot, Julia Lawall
cocci warnings: (new ones prefixed by >>)
>> drivers/net/phy/motorcomm.c:1122:8-35: duplicated argument to & or |
drivers/net/phy/motorcomm.c:1126:8-35: duplicated argument to & or |
drivers/net/phy/motorcomm.c:1130:8-34: duplicated argument to & or |
drivers/net/phy/motorcomm.c:1134:8-34: duplicated argument to & or |
The second YT8521_RC1R_GE_TX_DELAY_xx should be YT8521_RC1R_FE_TX_DELAY_xx.
Fixes: 70479a40954c ("net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Frank <Frank.Sae@motor-comm.com>
---
v1.2
-remove "[net-next,v8.2] " in Fixes tag
v1.1
-change PATCH net to PATCH net-next
-add warnings info
drivers/net/phy/motorcomm.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
index c7593f224177..bd1ab5d0631f 100644
--- a/drivers/net/phy/motorcomm.c
+++ b/drivers/net/phy/motorcomm.c
@@ -1119,19 +1119,19 @@ static int yt8521_config_init(struct phy_device *phydev)
switch (phydev->interface) {
case PHY_INTERFACE_MODE_RGMII:
- val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_GE_TX_DELAY_DIS;
+ val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_FE_TX_DELAY_DIS;
val |= YT8521_RC1R_RX_DELAY_DIS;
break;
case PHY_INTERFACE_MODE_RGMII_RXID:
- val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_GE_TX_DELAY_DIS;
+ val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_FE_TX_DELAY_DIS;
val |= YT8521_RC1R_RX_DELAY_EN;
break;
case PHY_INTERFACE_MODE_RGMII_TXID:
- val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_GE_TX_DELAY_EN;
+ val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_FE_TX_DELAY_EN;
val |= YT8521_RC1R_RX_DELAY_DIS;
break;
case PHY_INTERFACE_MODE_RGMII_ID:
- val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_GE_TX_DELAY_EN;
+ val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_FE_TX_DELAY_EN;
val |= YT8521_RC1R_RX_DELAY_EN;
break;
case PHY_INTERFACE_MODE_SGMII:
--
2.31.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next v1.2] net: phy: fix yt8521 duplicated argument to & or |
2022-11-03 6:14 [PATCH net-next v1.2] net: phy: fix yt8521 duplicated argument to & or | Frank
@ 2022-11-04 4:03 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-11-04 4:03 UTC (permalink / raw)
To: Frank
Cc: Peter Geis, Andrew Lunn, Heiner Kallweit, Russell King,
David S . Miller, Eric Dumazet, Paolo Abeni, yinghong.zhang,
fei.zhang, hua.sun, netdev, linux-kernel, kernel test robot,
Julia Lawall
On Thu, 3 Nov 2022 14:14:13 +0800 Frank wrote:
> cocci warnings: (new ones prefixed by >>)
> >> drivers/net/phy/motorcomm.c:1122:8-35: duplicated argument to & or |
> drivers/net/phy/motorcomm.c:1126:8-35: duplicated argument to & or |
> drivers/net/phy/motorcomm.c:1130:8-34: duplicated argument to & or |
> drivers/net/phy/motorcomm.c:1134:8-34: duplicated argument to & or |
>
> The second YT8521_RC1R_GE_TX_DELAY_xx should be YT8521_RC1R_FE_TX_DELAY_xx.
>
> Fixes: 70479a40954c ("net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Frank <Frank.Sae@motor-comm.com>
Please use your full legal name in the tag.
Please address the comments from the previous version, and read this:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr
Please use natural numbers for versioning - v1, v2, v3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-04 4:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-03 6:14 [PATCH net-next v1.2] net: phy: fix yt8521 duplicated argument to & or | Frank
2022-11-04 4:03 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).