* [PATCH -next v3] net: ethernet: Simplify bool conversion
@ 2022-11-04 6:37 Yang Li
2022-11-04 15:46 ` Andrew Lunn
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-11-04 6:37 UTC (permalink / raw)
To: richardcochran, bagasdotme
Cc: davem, edumazet, kuba, pabeni, netdev, linux-renesas-soc,
linux-kernel, Yang Li, Abaci Robot
The result of 'scaled_ppm < 0' is Boolean, and the question mark
expression is redundant, remove it to clear the below warning:
./drivers/net/ethernet/renesas/rcar_gen4_ptp.c:32:40-45: WARNING: conversion to bool not needed here
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2729
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
change in v3:
--According to Richard's suggestion, to preserve reverse Christmas tree order.
drivers/net/ethernet/renesas/rcar_gen4_ptp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c
index c007e33c47e1..0dc80f6bbf94 100644
--- a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c
+++ b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c
@@ -29,8 +29,8 @@ static const struct rcar_gen4_ptp_reg_offset s4_offs = {
static int rcar_gen4_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm)
{
struct rcar_gen4_ptp_private *ptp_priv = ptp_to_priv(ptp);
- bool neg_adj = scaled_ppm < 0 ? true : false;
s64 addend = ptp_priv->default_addend;
+ bool neg_adj = scaled_ppm < 0;
s64 diff;
if (neg_adj)
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next v3] net: ethernet: Simplify bool conversion
2022-11-04 6:37 [PATCH -next v3] net: ethernet: Simplify bool conversion Yang Li
@ 2022-11-04 15:46 ` Andrew Lunn
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2022-11-04 15:46 UTC (permalink / raw)
To: Yang Li
Cc: richardcochran, bagasdotme, davem, edumazet, kuba, pabeni, netdev,
linux-renesas-soc, linux-kernel, Abaci Robot
On Fri, Nov 04, 2022 at 02:37:31PM +0800, Yang Li wrote:
> The result of 'scaled_ppm < 0' is Boolean, and the question mark
> expression is redundant, remove it to clear the below warning:
>
> ./drivers/net/ethernet/renesas/rcar_gen4_ptp.c:32:40-45: WARNING: conversion to bool not needed here
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2729
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>
> change in v3:
> --According to Richard's suggestion, to preserve reverse Christmas tree order.
Don't send a new version of a patch for at least 24 hours.
https://docs.kernel.org/process/maintainer-netdev.html#tl-dr
People need time to review your patch and suggest how to make it
better.
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-04 15:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-04 6:37 [PATCH -next v3] net: ethernet: Simplify bool conversion Yang Li
2022-11-04 15:46 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).