From: Jakub Kicinski <kuba@kernel.org>
To: Nick Child <nnac123@linux.ibm.com>
Cc: netdev@vger.kernel.org, nick.child@ibm.com,
bjking1@linux.ibm.com, ricklind@us.ibm.com, dave.taht@gmail.com
Subject: Re: [PATCH v2 net] ibmveth: Reduce maximum tx queues to 8
Date: Fri, 4 Nov 2022 11:39:32 -0700 [thread overview]
Message-ID: <20221104113932.3377ebb7@kernel.org> (raw)
In-Reply-To: <a2924a54-7e44-952d-8544-d14e44d9d8f5@linux.ibm.com>
On Fri, 4 Nov 2022 13:15:39 -0500 Nick Child wrote:
> > Or is the concern coming from your recent work on BQL and having many
> > queues exacerbating buffer bloat?
>
> Yes, and Dave can jump in here if I am wrong, but, from my
> understanding, if the NIC cannot send packets at the rate that
> they are queued then these queues will inevitably fill to txqueuelen.
> In this case, having more queues will not mean better throughput but
> will result in a large number of allocations sitting in queues
> (bufferbloat). I believe Dave's point was, if more queues does not
> allow for better performance (and can risk bufferbloat) then why
> have so many at all.
>
> After going through testing and seeing no difference in performance
> with 8 vs 16 queues, I would rather not have the driver be a culprit
> of potential resource hogging.
Right, so my point was that user can always shoot themselves in the
foot with bad configs. You can leave the MAX at 16, in case someone
needs it. Limit the default real queues setting instead, most users
will use the default.
next prev parent reply other threads:[~2022-11-04 18:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 18:38 [PATCH v2 net] ibmveth: Reduce maximum tx queues to 8 Nick Child
2022-11-04 3:59 ` Jakub Kicinski
2022-11-04 14:06 ` Nick Child
2022-11-04 17:59 ` Jakub Kicinski
2022-11-04 18:15 ` Nick Child
2022-11-04 18:39 ` Jakub Kicinski [this message]
2022-11-05 11:33 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104113932.3377ebb7@kernel.org \
--to=kuba@kernel.org \
--cc=bjking1@linux.ibm.com \
--cc=dave.taht@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nick.child@ibm.com \
--cc=nnac123@linux.ibm.com \
--cc=ricklind@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).