* [PATCH] net: libwx: Remove variable dev to simplify code
@ 2022-11-03 7:19 Tang Bin
2022-11-04 18:48 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Tang Bin @ 2022-11-03 7:19 UTC (permalink / raw)
To: jiawenwu, mengyuanlou, davem, edumazet, kuba, pabeni
Cc: netdev, linux-kernel, Tang Bin
In the function wx_get_pcie_msix_counts(), the variable dev
is redundant, so remove it.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/net/ethernet/wangxun/libwx/wx_hw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
index 1eb7388f1..a7d79490e 100644
--- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c
+++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
@@ -883,13 +883,12 @@ EXPORT_SYMBOL(wx_reset_misc);
int wx_get_pcie_msix_counts(struct wx_hw *wxhw, u16 *msix_count, u16 max_msix_count)
{
struct pci_dev *pdev = wxhw->pdev;
- struct device *dev = &pdev->dev;
int pos;
*msix_count = 1;
pos = pci_find_capability(pdev, PCI_CAP_ID_MSIX);
if (!pos) {
- dev_err(dev, "Unable to find MSI-X Capabilities\n");
+ dev_err(&pdev->dev, "Unable to find MSI-X Capabilities\n");
return -EINVAL;
}
pci_read_config_word(pdev,
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net: libwx: Remove variable dev to simplify code
2022-11-03 7:19 [PATCH] net: libwx: Remove variable dev to simplify code Tang Bin
@ 2022-11-04 18:48 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-11-04 18:48 UTC (permalink / raw)
To: Tang Bin
Cc: jiawenwu, mengyuanlou, davem, edumazet, pabeni, netdev,
linux-kernel
On Thu, 3 Nov 2022 15:19:56 +0800 Tang Bin wrote:
> In the function wx_get_pcie_msix_counts(), the variable dev
> is redundant, so remove it.
This patch doesn't make any difference.
Please consider not sending similar patches to netdev.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-04 18:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-03 7:19 [PATCH] net: libwx: Remove variable dev to simplify code Tang Bin
2022-11-04 18:48 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).