From: coverity-bot <keescook@chromium.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Mengyuan Lou <mengyuanlou@net-swift.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Coverity: txgbe_calc_eeprom_checksum(): Control flow issues
Date: Fri, 4 Nov 2022 12:25:40 -0700 [thread overview]
Message-ID: <202211041225.FF75B11482@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20221104 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Wed Nov 2 12:31:23 2022 +0000
049fe5365324 ("net: txgbe: Add operations to interact with firmware")
Coverity reported the following:
*** CID 1527152: Control flow issues (NO_EFFECT)
drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c:200 in txgbe_calc_eeprom_checksum()
194
195 for (i = 0; i < TXGBE_EEPROM_LAST_WORD; i++)
196 if (i != wxhw->eeprom.sw_region_offset + TXGBE_EEPROM_CHECKSUM)
197 *checksum += local_buffer[i];
198
199 *checksum = TXGBE_EEPROM_SUM - *checksum;
vvv CID 1527152: Control flow issues (NO_EFFECT)
vvv This less-than-zero comparison of an unsigned value is never true. "*checksum < 0".
200 if (*checksum < 0)
201 return -EINVAL;
202
203 if (eeprom_ptrs)
204 kvfree(eeprom_ptrs);
205
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1527152 ("Control flow issues")
Fixes: 049fe5365324 ("net: txgbe: Add operations to interact with firmware")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2022-11-04 19:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202211041225.FF75B11482@keescook \
--to=keescook@chromium.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavo@embeddedor.com \
--cc=jiawenwu@trustnetic.com \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).