From: Jakub Kicinski <kuba@kernel.org>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, Florian Fainelli <f.fainelli@gmail.com>,
Michael Chan <michael.chan@broadcom.com>,
Andrew Lunn <andrew@lunn.ch>,
corbet@lwn.net, hkallweit1@gmail.com, huangguangbin2@huawei.com,
chenhao288@hisilicon.com, moshet@nvidia.com,
linux@rempel-privat.de, linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next v5] ethtool: linkstate: add a statistic for PHY down events
Date: Fri, 4 Nov 2022 15:48:09 -0700 [thread overview]
Message-ID: <20221104154809.671ac378@kernel.org> (raw)
In-Reply-To: <Y2VzoD5uwW64yYgD@shell.armlinux.org.uk>
On Fri, 4 Nov 2022 20:18:40 +0000 Russell King (Oracle) wrote:
> I guess we'll need phylink to support this as well, so phylink using
> drivers can provide this statistic not only for phylib based PHYs, but
> also for direct SFP connections as well.
>
> Thinking about the complexities of copper SFPs that may contain a PHY,
> it seems to me that the sensible implementation would be for phylink
> to keep the counter and not use the phylib counter (as that PHY may
> be re-plugged and thus the count can reset back to zero) which I
> suspect userspace would not be prepared for.
Makes sense, having the counter go back on a netdev could be highly
confusing for local detection.
How would you like to proceed? I can try to take a stab at a phylink
implementation but a stab it will be.
next prev parent reply other threads:[~2022-11-04 22:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 19:01 [PATCH net-next v5] ethtool: linkstate: add a statistic for PHY down events Jakub Kicinski
2022-11-04 20:18 ` Russell King (Oracle)
2022-11-04 22:48 ` Jakub Kicinski [this message]
2022-11-08 10:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104154809.671ac378@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=chenhao288@hisilicon.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=huangguangbin2@huawei.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rempel-privat.de \
--cc=michael.chan@broadcom.com \
--cc=moshet@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).