From: Jakub Kicinski <kuba@kernel.org>
To: Michal Wilczynski <michal.wilczynski@intel.com>
Cc: netdev@vger.kernel.org, alexandr.lobakin@intel.com,
jacob.e.keller@intel.com, jesse.brandeburg@intel.com,
przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com,
ecree.xilinx@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH net-next v9 1/9] devlink: Introduce new attribute 'tx_priority' to devlink-rate
Date: Fri, 4 Nov 2022 19:10:21 -0700 [thread overview]
Message-ID: <20221104191021.588acef2@kernel.org> (raw)
In-Reply-To: <20221104143102.1120076-2-michal.wilczynski@intel.com>
On Fri, 4 Nov 2022 15:30:54 +0100 Michal Wilczynski wrote:
> + if (attrs[DEVLINK_ATTR_RATE_TX_PRIORITY] && !ops->rate_leaf_tx_priority_set) {
> + NL_SET_ERR_MSG_MOD(info->extack,
> + "TX priority set isn't supported for the leafs");
Please point to the attribute - NL_SET_ERR_MSG_ATTR().
I'm not entirely sure why we keep slapping the _MOD() on the extacks,
but if you care to keep that you may need to add the _MOD flavor of
the above.
next prev parent reply other threads:[~2022-11-05 2:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 14:30 [PATCH net-next v9 0/9] Implement devlink-rate API and extend it Michal Wilczynski
2022-11-04 14:30 ` [PATCH net-next v9 1/9] devlink: Introduce new attribute 'tx_priority' to devlink-rate Michal Wilczynski
2022-11-04 15:35 ` Jiri Pirko
2022-11-05 2:07 ` Jakub Kicinski
2022-11-07 18:15 ` Wilczynski, Michal
2022-11-05 2:10 ` Jakub Kicinski [this message]
2022-11-07 18:15 ` Wilczynski, Michal
2022-11-08 16:48 ` Jacob Keller
2022-11-04 14:30 ` [PATCH net-next v9 2/9] devlink: Introduce new attribute 'tx_weight' " Michal Wilczynski
2022-11-04 15:36 ` Jiri Pirko
2022-11-04 14:30 ` [PATCH net-next v9 3/9] devlink: Enable creation of the devlink-rate nodes from the driver Michal Wilczynski
2022-11-04 15:39 ` Jiri Pirko
2022-11-04 14:30 ` [PATCH net-next v9 4/9] devlink: Allow for devlink-rate nodes parent reassignment Michal Wilczynski
2022-11-04 14:30 ` [PATCH net-next v9 5/9] devlink: Allow to set up parent in devl_rate_leaf_create() Michal Wilczynski
2022-11-04 15:40 ` Jiri Pirko
2022-11-04 14:30 ` [PATCH net-next v9 6/9] ice: Introduce new parameters in ice_sched_node Michal Wilczynski
2022-11-04 14:31 ` [PATCH net-next v9 7/9] ice: Add an option to pre-allocate memory for ice_sched_node Michal Wilczynski
2022-11-05 2:12 ` Jakub Kicinski
2022-11-04 14:31 ` [PATCH net-next v9 8/9] ice: Implement devlink-rate API Michal Wilczynski
2022-11-04 14:31 ` [PATCH net-next v9 9/9] ice: Prevent ADQ, DCB coexistence with Custom Tx scheduler Michal Wilczynski
2022-11-05 2:05 ` [PATCH net-next v9 0/9] Implement devlink-rate API and extend it Jakub Kicinski
2022-11-07 18:18 ` Wilczynski, Michal
2022-11-07 18:31 ` Jakub Kicinski
2022-11-08 8:08 ` Wilczynski, Michal
2022-11-08 8:36 ` Wilczynski, Michal
2022-11-08 22:34 ` Jakub Kicinski
2022-11-08 16:54 ` Jacob Keller
2022-11-08 18:10 ` Wilczynski, Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104191021.588acef2@kernel.org \
--to=kuba@kernel.org \
--cc=alexandr.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ecree.xilinx@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@resnulli.us \
--cc=michal.wilczynski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).