netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alexander Aring <aahringo@redhat.com>
Cc: Alexander Aring <alex.aring@gmail.com>,
	Stefan Schmidt <stefan@datenfreihafen.org>,
	linux-wpan@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org, David Girault <david.girault@qorvo.com>,
	Romuald Despres <romuald.despres@qorvo.com>,
	Frederic Blain <frederic.blain@qorvo.com>,
	Nicolas Schodet <nico@ni.fr.eu.org>,
	Guilhem Imberton <guilhem.imberton@qorvo.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH wpan-next v2 0/3] IEEE 802.15.4: Add coordinator interfaces
Date: Mon, 7 Nov 2022 09:43:12 +0100	[thread overview]
Message-ID: <20221107094312.2f98c2cb@xps-13> (raw)
In-Reply-To: <CAK-6q+j4pCQNj5paCAXMNvtHi9+DHxW8wZH2-ZpbxKgpbe8R0Q@mail.gmail.com>

Hi Alexander,

aahringo@redhat.com wrote on Sun, 6 Nov 2022 20:30:48 -0500:

> Hi,
> 
> On Fri, Nov 4, 2022 at 2:17 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > Hi Alexander,
> >
> > aahringo@redhat.com wrote on Thu, 3 Nov 2022 20:55:38 -0400:
> >  
> > > Hi,
> > >
> > > On Wed, Nov 2, 2022 at 10:52 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:  
> > > >
> > > > Hi Alexander,
> > > >
> > > > aahringo@redhat.com wrote on Sun, 30 Oct 2022 22:20:03 -0400:
> > > >  
> > > > > Hi,
> > > > >
> > > > > On Wed, Oct 26, 2022 at 5:35 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:  
> > > > > >
> > > > > > Hello,
> > > > > > These three patches allow the creation of coordinator interfaces, which
> > > > > > were already defined without being usable. The idea behind is to use
> > > > > > them advertizing PANs through the beaconing feature.
> > > > > >  
> > > > >
> > > > > I still don't know how exactly those "leaves" and "non-leaves" are
> > > > > acting here regarding the coordinator interfaces. If this is just a
> > > > > bit here to set in the interface I am fine with it. But yea,
> > > > > "relaying" feature is a project on its own, as we said previously.
> > > > >
> > > > > Another mail I was asking myself what a node interface is then,
> > > > > currently it is a mesh interface with none of those 802.15.4 PAN
> > > > > management functionality?  
> > > >
> > > > Not "none", because I would expect a NODE to be able to perform minimal
> > > > management operations, such as:
> > > > - scanning
> > > > - requesting an association
> > > > But in no case it is supposed to:
> > > > - send beacons
> > > > - manage associations
> > > > - be the PAN coordinator
> > > > - act as a relay
> > > >  
> > >
> > > perfect, thanks. But still there is something which I don't get.
> > >
> > > The split you mentioned about the functionality is for me being a
> > > coordinator (IEEE spec) or pan coordinator (IEEE spec) which has the
> > > additional functionality of "send beacons, manage assocs, act as
> > > relay".  
> >
> > I would expect any coordinator (IEEE spec) to be able to send beacons
> > and relay (but in this case it only makes sense to send beacons if
> > relaying is supported, IMHO).
> >
> > The PAN coordinator (IEEE spec) only has the following additional
> > capability: managing assocs within the PAN. But in practice it is very
> > likely that it is the one with the greater computational resources and
> > the highest networking capabilities (it is usually the one which acts
> > as a bridge with eg. the internet, says the spec).
> >  
> > > So a coordinator (iftype) is a pan coordinator (IEEE spec) and a node
> > > (iftype) is a coordinator (IEEE spec), but _only_ when it's
> > > associated, before it is just a manually setup mesh node?  
> >
> > Mmmh, actually this is not how I see it. My current mental model:
> > - COORD (iftype) may act as:
> >   * a leaf device (associating with the PAN coordinator, sending data)
> >   * a coordinator (like above + beaconing and relaying) once associated
> >   * a PAN coordinator (like above + assoc management) if the device
> >     started the PAN or after a PAN coordinator handover.
> >   Note: physically, it can only be authorized on FFD.
> > - NODE (iftype) may only be a leaf device no matter its association
> >   status, this is typically a sensor that sends data.
> >   Note: can be authorized on any type of device (FFD or RFD).
> >
> > If I understand correctly, your idea was to change the interface type
> > depending of the role of the device within the network. But IMHO the
> > interface type should only be picked up once for all in the lifetime of
> > the device. Of course we can switch from one to another by quickly
> > turning off and on again the device, but this is not a common use case.
> > We must keep in mind that PAN coordinator handover may happen, which
> > means the interface must stay on but stop acting as the PAN
> > coordinator. Using two different interface types for that is not
> > impossible, but does not seem relevant to me.
> >
> > Would you agree?
> >  
> 
> Okay, I think that if you have a node then you never want to act as
> any PAN coordinators functionality. And yes it seems complicated to
> switch such functionality during runtime. I am fine with that.

Great!

> The
> future will show if there are any "special" requirements and how we
> could react here.

Agreed.

> > > I hope it's clear when meaning iftype and when meaning IEEE spec, but
> > > for the manual setup thing (node iftype) there is no IEEE spec,
> > > although it is legal to do it in my opinion.  
> >
> > It's clear, no problem. In my previous e-mails, when talking about the
> > interfaces I used the uppercase NODE and COORD keywords, while I used
> > the plain english lowercase "[leaf] node", "coordinator" or "PAN
> > coordinator" words when talking about the IEEE definitions.
> >  
> 
> That is great, we should use those terms to make the difference.

Ok, I'll do!

Thanks,
Miquèl

  reply	other threads:[~2022-11-07  8:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26  9:34 [PATCH wpan-next v2 0/3] IEEE 802.15.4: Add coordinator interfaces Miquel Raynal
2022-10-26  9:35 ` [PATCH wpan-next v2 1/3] mac802154: Move an skb free within the rx path Miquel Raynal
2022-10-26  9:35 ` [PATCH wpan-next v2 2/3] mac802154: Clarify an expression Miquel Raynal
2022-10-26  9:35 ` [PATCH wpan-next v2 3/3] mac802154: Allow the creation of coordinator interfaces Miquel Raynal
2022-10-31  2:20 ` [PATCH wpan-next v2 0/3] IEEE 802.15.4: Add " Alexander Aring
2022-10-31 22:07   ` Alexander Aring
2022-11-02 14:52   ` Miquel Raynal
2022-11-04  0:55     ` Alexander Aring
2022-11-04 18:17       ` Miquel Raynal
2022-11-07  1:30         ` Alexander Aring
2022-11-07  8:43           ` Miquel Raynal [this message]
2022-11-01 10:27 ` Stefan Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221107094312.2f98c2cb@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=aahringo@redhat.com \
    --cc=alex.aring@gmail.com \
    --cc=davem@davemloft.net \
    --cc=david.girault@qorvo.com \
    --cc=edumazet@google.com \
    --cc=frederic.blain@qorvo.com \
    --cc=guilhem.imberton@qorvo.com \
    --cc=kuba@kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nico@ni.fr.eu.org \
    --cc=pabeni@redhat.com \
    --cc=romuald.despres@qorvo.com \
    --cc=stefan@datenfreihafen.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).