Hi Hangbin, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] url: https://github.com/intel-lab-lkp/linux/commits/Hangbin-Liu/bonding-fix-ICMPv6-header-handling-when-receiving-IPv6-messages/20221108-160309 patch link: https://lore.kernel.org/r/20221108070035.177036-1-liuhangbin%40gmail.com patch subject: [PATCHv2 net] bonding: fix ICMPv6 header handling when receiving IPv6 messages config: arm-randconfig-r022-20221108 compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 463da45892e2d2a262277b91b96f5f8c05dc25d0) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/intel-lab-lkp/linux/commit/5e0e0829758bb233fee4eaaf620edce9dcfc53ac git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Hangbin-Liu/bonding-fix-ICMPv6-header-handling-when-receiving-IPv6-messages/20221108-160309 git checkout 5e0e0829758bb233fee4eaaf620edce9dcfc53ac # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/net/bonding/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/net/bonding/bond_main.c:3242:70: error: passing 'const struct icmp6hdr *' to parameter of type 'void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] hdr = skb_header_pointer(skb, sizeof(struct ipv6hdr), sizeof(_hdr), &_hdr); ^~~~~ include/linux/skbuff.h:3998:74: note: passing argument to parameter 'buffer' here skb_header_pointer(const struct sk_buff *skb, int offset, int len, void *buffer) ^ 1 error generated. vim +3242 drivers/net/bonding/bond_main.c 3229 3230 static int bond_na_rcv(const struct sk_buff *skb, struct bonding *bond, 3231 struct slave *slave) 3232 { 3233 struct slave *curr_active_slave, *curr_arp_slave; 3234 const struct icmp6hdr *hdr, _hdr; 3235 struct in6_addr *saddr, *daddr; 3236 3237 if (skb->pkt_type == PACKET_OTHERHOST || 3238 skb->pkt_type == PACKET_LOOPBACK || 3239 ipv6_hdr(skb)->nexthdr != NEXTHDR_ICMP) 3240 goto out; 3241 > 3242 hdr = skb_header_pointer(skb, sizeof(struct ipv6hdr), sizeof(_hdr), &_hdr); 3243 if (!hdr || hdr->icmp6_type != NDISC_NEIGHBOUR_ADVERTISEMENT) 3244 goto out; 3245 3246 saddr = &ipv6_hdr(skb)->saddr; 3247 daddr = &ipv6_hdr(skb)->daddr; 3248 3249 slave_dbg(bond->dev, slave->dev, "%s: %s/%d av %d sv %d sip %pI6c tip %pI6c\n", 3250 __func__, slave->dev->name, bond_slave_state(slave), 3251 bond->params.arp_validate, slave_do_arp_validate(bond, slave), 3252 saddr, daddr); 3253 3254 curr_active_slave = rcu_dereference(bond->curr_active_slave); 3255 curr_arp_slave = rcu_dereference(bond->current_arp_slave); 3256 3257 /* We 'trust' the received ARP enough to validate it if: 3258 * see bond_arp_rcv(). 3259 */ 3260 if (bond_is_active_slave(slave)) 3261 bond_validate_na(bond, slave, saddr, daddr); 3262 else if (curr_active_slave && 3263 time_after(slave_last_rx(bond, curr_active_slave), 3264 curr_active_slave->last_link_up)) 3265 bond_validate_na(bond, slave, saddr, daddr); 3266 else if (curr_arp_slave && 3267 bond_time_in_interval(bond, slave_last_tx(curr_arp_slave), 1)) 3268 bond_validate_na(bond, slave, saddr, daddr); 3269 3270 out: 3271 return RX_HANDLER_ANOTHER; 3272 } 3273 #endif 3274 -- 0-DAY CI Kernel Test Service https://01.org/lkp