From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84D59C433FE for ; Thu, 10 Nov 2022 17:01:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232694AbiKJRBj (ORCPT ); Thu, 10 Nov 2022 12:01:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232775AbiKJRBa (ORCPT ); Thu, 10 Nov 2022 12:01:30 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AB8022538 for ; Thu, 10 Nov 2022 09:01:30 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E9471619C2 for ; Thu, 10 Nov 2022 17:01:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDBFEC433D7; Thu, 10 Nov 2022 17:01:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668099689; bh=Vte/R+utRWDDPFwFpYBVIZx06W0dHSOQa6BdKVQcFTo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MX7uF4SHfTxHKrAYW5xXAhzZ61maTEdUDoUYUJjqEP7YS6tFCp5AZeBI4//panTBu OSN5MAV57YKOAvBRe4Nv6q0DTyhVo1LecYNDk4pNYKvOSoJv0VEzU/IpyHp7EATaxZ 8f4OEVz0/cetn849Zt8qTwJTn672syz8IuBuwL+c2blY8lIoPZEVAlCjzqWvs4QAXZ YBYxKEjEvoDpXT6MGn6oHHPhJeWyan/Z1oi6t9K2B06amsduTSCIqyqkNdwetqgJf8 8nbZWsActPj5dEZ+QfKO/2ghfMc1bZmSS4gl9Xira+R+uHg/F4VaI1l10JwoBLWyED D/JOUyoyds1ow== Date: Thu, 10 Nov 2022 09:01:27 -0800 From: Jakub Kicinski To: Leon Romanovsky Cc: Vincent MAILHOL , netdev@vger.kernel.org, "David S . Miller" , Eric Dumazet , Paolo Abeni , Guangbin Huang , Sean Anderson , Tom Rix , Tonghao Zhang , Wolfram Sang , Marco Bonelli Subject: Re: [PATCH net-next v1] ethtool: ethtool_get_drvinfo: populate drvinfo fields even if callback exits Message-ID: <20221110090127.0d729f05@kernel.org> In-Reply-To: References: <20221108035754.2143-1-mailhol.vincent@wanadoo.fr> <20221109122641.781b30d9@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 10 Nov 2022 11:11:38 +0200 Leon Romanovsky wrote: > I will be happy to see such patch and will review it, but can't add sign-off > as I'm not netdev maintainer. Did we finish the version removal work? :S Personally I'd rather direct any effort towards writing a checkpatch / cocci / python check that catches new cases than cleaning up the pile of drivers we have. A lot of which are not actively used..