From: Stephen Hemminger <stephen@networkplumber.org>
To: Jamie Bainbridge <jamie.bainbridge@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tcp: Add listening address to SYN flood message
Date: Thu, 10 Nov 2022 15:39:01 -0800 [thread overview]
Message-ID: <20221110153901.7daa86e1@hermes.local> (raw)
In-Reply-To: <f847459dc0a0e2d8ffa1d290d06e0e4a226a6f39.1668075479.git.jamie.bainbridge@gmail.com>
On Thu, 10 Nov 2022 21:21:06 +1100
Jamie Bainbridge <jamie.bainbridge@gmail.com> wrote:
> + xchg(&queue->synflood_warned, 1) == 0) {
> +#if IS_ENABLED(CONFIG_IPV6)
> + if (sk->sk_family == AF_INET6) {
> + net_info_ratelimited("%s: Possible SYN flooding on port %d. IP %pI6c. %s. Check SNMP counters.\n",
> + proto, sk->sk_num,
> + &sk->sk_v6_rcv_saddr, msg);
> + } else
> +#endif
> + {
> + net_info_ratelimited("%s: Possible SYN flooding on port %d. IP %pI4. %s. Check SNMP counters.\n",
> + proto, sk->sk_num, &sk->sk_rcv_saddr, msg);
> + }
> + }
>
Port number is unsigned not signed.
Message also seems overly wordy to me.
next prev parent reply other threads:[~2022-11-10 23:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 10:21 [PATCH] tcp: Add listening address to SYN flood message Jamie Bainbridge
2022-11-10 13:51 ` Andrew Lunn
2022-11-10 21:20 ` Jamie Bainbridge
2022-11-10 22:30 ` Andrew Lunn
2022-11-15 10:29 ` Geert Uytterhoeven
2022-11-10 23:39 ` Stephen Hemminger [this message]
2022-11-10 23:46 ` Eric Dumazet
2022-11-11 0:38 ` Jamie Bainbridge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221110153901.7daa86e1@hermes.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jamie.bainbridge@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox