From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Roger Quadros <rogerq@kernel.org>,
Ido Schimmel <idosch@idosch.org>,
Nikolay Aleksandrov <razor@blackwall.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"vigneshr@ti.com" <vigneshr@ti.com>, "srk@ti.com" <srk@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: ethernet: ti: cpsw_ale: optimize cpsw_ale_restore()
Date: Fri, 11 Nov 2022 12:03:54 +0000 [thread overview]
Message-ID: <20221111120350.waumn6x35vwfnrfc@skbuf> (raw)
In-Reply-To: <20221110123249.5f0e19df@kernel.org>
On Thu, Nov 10, 2022 at 12:32:49PM -0800, Jakub Kicinski wrote:
> > I have a question here. How should ageable entries be treated in this case?
>
> Ah, no idea :) Let's me add experts to To:
Not a real expert, but if suspend/resume loses the Ethernet link,
I expect that no dynamically learned entries are preserved across
a link loss event.
In DSA for example, we only keep ageable entries in hardware as long as
the port STP state, plus BR_LEARNING port flag, are compatible with
having such FDB entries. Otherwise, any transition to such a state
flushes the ageable FDB entries.
A link loss generates a bridge port transition to the DISABLED state,
which DSA uses to generate a SWITCHDEV_FDB_FLUSH_TO_BRIDGE event.
I'm not sure if it would even be possible to accurately do the right
thing and update the ageing timer of the FDB entries with the amount of
time that the system was suspended.
next prev parent reply other threads:[~2022-11-11 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 13:56 [PATCH] net: ethernet: ti: cpsw_ale: optimize cpsw_ale_restore() Roger Quadros
2022-11-10 3:19 ` Jakub Kicinski
2022-11-10 9:39 ` Roger Quadros
2022-11-10 20:32 ` Jakub Kicinski
2022-11-11 10:25 ` Roger Quadros
2022-11-11 12:03 ` Vladimir Oltean [this message]
2022-11-11 13:35 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111120350.waumn6x35vwfnrfc@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox