From: Vladimir Oltean <olteanv@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: kuba@kernel.org, andrew@lunn.ch, netdev@vger.kernel.org,
"Steffen Bätz" <steffen@innosonix.de>,
"Fabio Estevam" <festevam@denx.de>
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: Allow hwstamping on the master port
Date: Fri, 11 Nov 2022 23:41:27 +0200 [thread overview]
Message-ID: <20221111214127.pzek6eonetzatc4a@skbuf> (raw)
In-Reply-To: <CAOMZO5D9shR2WB+83UPOvs-CaRg7rmaZ-USokPu0K+jtvB2EYw@mail.gmail.com>
On Fri, Nov 11, 2022 at 08:13:56AM -0300, Fabio Estevam wrote:
> Hi Vladimir,
>
> On Thu, Nov 10, 2022 at 9:53 AM Vladimir Oltean <olteanv@gmail.com> wrote:
>
> > NACK.
> >
> > Please extend dsa_master_ioctl() to "see through" the dp->ds->ops->port_hwtstamp_get()
> > pointer, similar to what dsa_port_can_configure_learning() does. Create
> > a fake struct ifreq, call port_hwtstamp_get(), see if it returned
> > -EOPNOTSUPP, and wrap that into a dsa_port_supports_hwtstamp() function,
> > and call that instead of the current simplistic checks for the function
> > pointers.
>
> I tried to implement what you suggested in the attached patch, but I
> am not sure it is correct.
>
> If it doesn't work, please cook a patch so we can try it.
Yeah, this is not what I meant. I posted a patch illustrating what I
meant here:
https://patchwork.kernel.org/project/netdevbpf/patch/20221111211020.543540-1-vladimir.oltean@nxp.com/
next prev parent reply other threads:[~2022-11-11 21:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 12:43 [PATCH net-next] net: dsa: mv88e6xxx: Allow hwstamping on the master port Fabio Estevam
2022-11-10 12:53 ` Vladimir Oltean
2022-11-11 11:13 ` Fabio Estevam
2022-11-11 21:41 ` Vladimir Oltean [this message]
2022-11-12 0:06 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111214127.pzek6eonetzatc4a@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen@innosonix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox