From: David Ahern <dsahern@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH net-next v2] netlink: split up copies in the ack construction
Date: Sun, 13 Nov 2022 19:39:27 -0700 [thread overview]
Message-ID: <20221114023927.GA685@u2004-local> (raw)
In-Reply-To: <20221027212553.2640042-1-kuba@kernel.org>
On Thu, Oct 27, 2022 at 02:25:53PM -0700, Jakub Kicinski wrote:
> diff --git a/include/uapi/linux/netlink.h b/include/uapi/linux/netlink.h
> index e2ae82e3f9f7..5da0da59bf01 100644
> --- a/include/uapi/linux/netlink.h
> +++ b/include/uapi/linux/netlink.h
> @@ -48,6 +48,7 @@ struct sockaddr_nl {
> * @nlmsg_flags: Additional flags
> * @nlmsg_seq: Sequence number
> * @nlmsg_pid: Sending process port ID
> + * @nlmsg_data: Message payload
> */
> struct nlmsghdr {
> __u32 nlmsg_len;
> @@ -55,6 +56,7 @@ struct nlmsghdr {
> __u16 nlmsg_flags;
> __u32 nlmsg_seq;
> __u32 nlmsg_pid;
> + __u8 nlmsg_data[];
This breaks compile of iproute2 with clang. It does not like the
variable length array in the middle of a struct. While I could re-do the
structs in iproute2, I doubt it is alone in being affected by this
change.
next prev parent reply other threads:[~2022-11-14 2:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 21:25 [PATCH net-next v2] netlink: split up copies in the ack construction Jakub Kicinski
2022-10-31 9:20 ` patchwork-bot+netdevbpf
2022-11-14 2:39 ` David Ahern [this message]
2022-11-14 17:06 ` Jakub Kicinski
2022-11-16 22:53 ` Kees Cook
2022-11-16 22:56 ` Kees Cook
2022-11-17 0:27 ` Kees Cook
2022-11-17 0:55 ` Gustavo A. R. Silva
2022-11-17 1:05 ` Jakub Kicinski
2022-11-17 1:20 ` Gustavo A. R. Silva
2022-11-17 6:13 ` Jakub Kicinski
2022-11-17 16:25 ` Stephen Hemminger
2022-11-17 20:36 ` Jakub Kicinski
2022-11-17 22:35 ` Kees Cook
2022-11-18 0:28 ` Jakub Kicinski
2022-11-18 3:27 ` Kees Cook
2022-11-18 15:59 ` David Ahern
2022-11-18 2:37 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221114023927.GA685@u2004-local \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).