From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34CA8C433FE for ; Tue, 15 Nov 2022 00:43:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231879AbiKOAn5 (ORCPT ); Mon, 14 Nov 2022 19:43:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231466AbiKOAn4 (ORCPT ); Mon, 14 Nov 2022 19:43:56 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B90391704B for ; Mon, 14 Nov 2022 16:43:55 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 73E52B810A0 for ; Tue, 15 Nov 2022 00:43:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC976C433D6; Tue, 15 Nov 2022 00:43:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668473033; bh=mmvSFYUkaAqPI0HV9MfjCC1iViIR0ag7KOgEuRk3IiY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mghwUDdlyMMZ92q9l2lxvYPtDBXu8dfO0Uw4m7pl8FjpF1nS23AR2yU/QBK+WN7oA vTRg8S1ZszxkpVAOce3riwjSHHdVugfelNPBwl8/Rhw5ZOFajI18xK6nSQLCoAgoHR 3Iuob7ZzQ32eEl8FxEfe6pZ6JwLI1fL7+GKdO4mLS5afi3OIHoKXsz4NxV2YxOX0VZ rQBJ+hh+uDG+WWXPCyfJ6XiX59poWk3Qj5BWcSiKhTM6iCDDTdJZxdfSftptlApKRG UdoqHIZgYNS4cKfz6TX58jl6NnNl9ou5xlznmTPziEM60RN+XLwXX5h6/TxWZWEbt3 lPtsTogiXtlTg== Date: Mon, 14 Nov 2022 16:43:52 -0800 From: Jakub Kicinski To: =?UTF-8?B?QmrDuHJu?= Mork Cc: Daniele Palmas , David Miller , Paolo Abeni , Eric Dumazet , Subash Abhinov Kasiviswanathan , Sean Tranchetti , Jonathan Corbet , Greg Kroah-Hartman , netdev@vger.kernel.org Subject: Re: [PATCH net-next 2/3] net: qualcomm: rmnet: add tx packets aggregation Message-ID: <20221114164352.7dbb575f@kernel.org> In-Reply-To: <87tu31hlyb.fsf@miraculix.mork.no> References: <20221109180249.4721-1-dnlplm@gmail.com> <20221109180249.4721-3-dnlplm@gmail.com> <20221111091440.51f9c09e@kernel.org> <87tu31hlyb.fsf@miraculix.mork.no> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 14 Nov 2022 11:25:32 +0100 Bj=C3=B8rn Mork wrote: > It looks like an attempt to "cheat" latency measurements. I don't think > we should do that. Aggregation may be necessary to achieve maximum > throughput in a radio network, but has its obvious bufferbloat downside. > Let's not hide that fact. Users deserve to know, and tune their systems > accordingly. Things like this will only make that more difficult =F0=9F=91=8D