From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Saeed Mahameed <saeed@kernel.org>,
David Thompson <davthompson@nvidia.com>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, cai.huoqing@linux.dev, brgl@bgdev.pl,
limings@nvidia.com, chenhao288@hisilicon.com,
huangguangbin2@huawei.com, Asmaa Mnebhi <asmaa@nvidia.com>
Subject: Re: [PATCH net-next v2 3/4] mlxbf_gige: add BlueField-3 Serdes configuration
Date: Mon, 14 Nov 2022 17:13:05 -0800 [thread overview]
Message-ID: <20221114171305.6af508be@kernel.org> (raw)
In-Reply-To: <Y3LmC7r4YP++q8fa@lunn.ch>
On Tue, 15 Nov 2022 02:06:19 +0100 Andrew Lunn wrote:
> > I am not advocating for black magic tables of course :), but how do we
> > > avoid them if request_firmware() will be an overkill to configure such a
> > > simple device? Express such data in a developer friendly c structures
> > > with somewhat sensible field names?
> >
> > I don't feel particularly strongly but seems like something worth
> > exploring. A minor advantage is that once the init is done the tables
> > can be discarded from memory.
>
> I wondered about that, but i'm not sure initdata works for modules,
> and for hot pluggable devices like PCIe, you never know when another
> one might appear and you need the tables.
Right, I meant that the request_firmware() version can discard
the tables. I shouldn't have said tables :)
next prev parent reply other threads:[~2022-11-15 1:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 22:47 [PATCH net-next v2 0/4] mlxbf_gige: add BlueField-3 support David Thompson
2022-11-09 22:47 ` [PATCH net-next v2 1/4] mlxbf_gige: add MDIO support for BlueField-3 David Thompson
2022-11-10 13:24 ` Andrew Lunn
2022-11-09 22:47 ` [PATCH net-next v2 2/4] mlxbf_gige: support 10M/100M/1G speeds on BlueField-3 David Thompson
2022-11-10 13:23 ` Andrew Lunn
2022-11-09 22:47 ` [PATCH net-next v2 3/4] mlxbf_gige: add BlueField-3 Serdes configuration David Thompson
2022-11-10 13:33 ` Andrew Lunn
2022-11-12 5:34 ` Jakub Kicinski
2022-11-12 9:52 ` Saeed Mahameed
2022-11-12 15:53 ` Andrew Lunn
2022-11-15 0:56 ` Jakub Kicinski
2022-11-15 0:50 ` Jakub Kicinski
2022-11-15 1:06 ` Andrew Lunn
2022-11-15 1:13 ` Jakub Kicinski [this message]
2022-11-16 16:30 ` Jakub Kicinski
2022-11-17 2:01 ` Saeed Mahameed
2022-11-17 6:23 ` Jakub Kicinski
2022-11-09 22:47 ` [PATCH net-next v2 4/4] mlxbf_gige: add "set_link_ksettings" ethtool callback David Thompson
2022-11-10 13:26 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221114171305.6af508be@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=asmaa@nvidia.com \
--cc=brgl@bgdev.pl \
--cc=cai.huoqing@linux.dev \
--cc=chenhao288@hisilicon.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=edumazet@google.com \
--cc=huangguangbin2@huawei.com \
--cc=limings@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).