From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39B28C4332F for ; Tue, 15 Nov 2022 02:02:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236456AbiKOCC1 (ORCPT ); Mon, 14 Nov 2022 21:02:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236364AbiKOCCY (ORCPT ); Mon, 14 Nov 2022 21:02:24 -0500 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E8B41742C for ; Mon, 14 Nov 2022 18:02:23 -0800 (PST) Received: by mail-pg1-x535.google.com with SMTP id f3so5529798pgc.2 for ; Mon, 14 Nov 2022 18:02:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=AmJ3WVaf971ZjU4+2fbtOTXgV6BCS6K8+zrP1YYCla0=; b=EfNzlZr3IsUeGSufFh31qoO4hs34DdGwSob09sGJ/Kx9BTEqneKIgycxZktE0IUBki W5t3GzN8Hi/eJSU/LOgCswTBpzGuj6CioC7dn7oYq09phiZX3gXJkH0BK2xDmeaFhPhu xbahOmn466w99CE560SZQHnXHabpZLRUw5VC4xMfFjQ2nvUeeaqe2ODjr1DhISs5ITHn jFU8Ae+znyuJRorJs0pR5i7H1Iq2waQq+tfLVx54YYGs4PdbQfynYX82/BYPZoNiFUHF iABznkPDxhMrefED4JR0TBv6L/A5eeUNydCTVtSHZlOcd4H0umagyIInVt7cGNYgdOoH q1Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AmJ3WVaf971ZjU4+2fbtOTXgV6BCS6K8+zrP1YYCla0=; b=k02jC0zhEwuTUfNbJWUn1TNXVUtLiLH6FL04gT3/jCHYVtsNtzSY1Z9MnTYf+0DcPd cx114yWUD+ecViQjsq1A7QkYEe+nHlFlg/Vn7h6FVoDEkaUquyHsjCwQ2TruMgzZvRX8 qOMeKp5icVsAOuA/Mgnbhp1aJvI1YiRv2AkPVjUamPV/zeL/vTq1cwViIwoqkyX+veVf EuaH/CpvgumlEeZ2PfXiI80+PIoDBVBjkgIIR6EYMkr0iGDdleo/iu+Pm3KZfz8QNY5B jidl4XPaef0/XylFxXnSI1J74JcKuwKoz9Qvd5J16XgrNmq0xv7WqUrvapi39ckpMcxT /PGg== X-Gm-Message-State: ANoB5pkj4jHzkPNfAibIGh/KqGIfO43zWlPV3okYPp4iQszbEf1KRj7H aQ3am6gn8QZ6+ayYU2BnG8ApiA== X-Google-Smtp-Source: AA0mqf5qfYh941ljJwblEN4jOl7IZk3RSBx4ODAwqwTr+huvkqndZ6JMjT6kGqecE7gxWZ5m89jP6g== X-Received: by 2002:aa7:8434:0:b0:56c:12c0:aaf1 with SMTP id q20-20020aa78434000000b0056c12c0aaf1mr16317032pfn.50.1668477742550; Mon, 14 Nov 2022 18:02:22 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id i187-20020a6287c4000000b0056262811c5fsm7409601pfe.59.2022.11.14.18.02.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Nov 2022 18:02:22 -0800 (PST) Date: Mon, 14 Nov 2022 18:02:19 -0800 From: Stephen Hemminger To: Eric Dumazet Cc: Jamie Bainbridge , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] tcp: Add listening address to SYN flood message Message-ID: <20221114180219.0a9900f4@hermes.local> In-Reply-To: References: <4fedab7ce54a389aeadbdc639f6b4f4988e9d2d7.1668386107.git.jamie.bainbridge@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 14 Nov 2022 09:31:38 -0800 Eric Dumazet wrote: > On Sun, Nov 13, 2022 at 5:00 PM Jamie Bainbridge > wrote: > > > > The SYN flood message prints the listening port number, but with many > > processes bound to the same port on different IPs, it's impossible to > > tell which socket is the problem. > > > > Add the listen IP address to the SYN flood message. > > > > For IPv6 use "[IP]:port" as per RFC-5952 and to provide ease of > > copy-paste to "ss" filters. For IPv4 use "IP:port" to match. > > > > Each protcol's "any" address and a host address now look like: > > > > Possible SYN flooding on port 0.0.0.0:9001. > > Possible SYN flooding on port 127.0.0.1:9001. > > Possible SYN flooding on port [::]:9001. > > Possible SYN flooding on port [fc00::1]:9001. > > > > Signed-off-by: Jamie Bainbridge > > --- > > Reviewed-by: Eric Dumazet Thanks for cleaning this up. Reviewed-by: Stephen Hemminger