From: Vladimir Oltean <olteanv@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Felix Fietkau <nbd@nbd.name>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 1/4] net: dsa: add support for DSA rx offloading via metadata dst
Date: Mon, 14 Nov 2022 20:19:26 +0200 [thread overview]
Message-ID: <20221114181926.ms5yl5rwzx7oonzn@skbuf> (raw)
In-Reply-To: <50a9e9c1-68d6-4edd-42e2-c5b8a9ac7e8a@gmail.com>
On Mon, Nov 14, 2022 at 09:59:09AM -0800, Florian Fainelli wrote:
> On 11/14/22 04:42, Felix Fietkau wrote:
> > If a metadata dst is present with the type METADATA_HW_PORT_MUX on a dsa cpu
> > port netdev, assume that it carries the port number and that there is no DSA
> > tag present in the skb data.
> >
> > Signed-off-by: Felix Fietkau <nbd@nbd.name>
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Is the plan to use the lwoer bits of the 32-bit port_id as the port number
> for now, and we can use the remaining 24 or so bits for passing
> classification (reason why we forward the packet, QoS etc. ) information in
> the future?
>
> Might be time for me to revive the systemport patches supporting Broadcom
> tags in the the DMA descriptor.
It's not really clear how to expand the HW_PORT_MUX model to provide QoS
info and trap reason, without switching to per-packet allocation, which
is what Jakub seemingly wanted to avoid with skb extensions (among other
more minor things).
https://patchwork.kernel.org/project/netdevbpf/patch/20221104174151.439008-4-maxime.chevallier@bootlin.com/#25078661
Felix didn't present a need for more than the port id either, so this is
why we have what we have right now.
next prev parent reply other threads:[~2022-11-14 18:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 12:42 [PATCH net-next v4 0/4] mtk_eth_soc rx vlan offload improvement + dsa hardware untag support Felix Fietkau
2022-11-14 12:42 ` [PATCH net-next v4 1/4] net: dsa: add support for DSA rx offloading via metadata dst Felix Fietkau
2022-11-14 16:59 ` Vladimir Oltean
2022-11-14 17:59 ` Florian Fainelli
2022-11-14 18:19 ` Vladimir Oltean [this message]
2022-11-14 12:42 ` [PATCH net-next v4 2/4] net: ethernet: mtk_eth_soc: pass correct VLAN protocol ID to the network stack Felix Fietkau
2022-11-14 12:42 ` [PATCH net-next v4 3/4] net: ethernet: mtk_eth_soc: add support for configuring vlan rx offload Felix Fietkau
2022-11-14 12:42 ` [PATCH net-next v4 4/4] net: ethernet: mtk_eth_soc: enable hardware DSA untagging Felix Fietkau
2022-11-16 4:30 ` [PATCH net-next v4 0/4] mtk_eth_soc rx vlan offload improvement + dsa hardware untag support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221114181926.ms5yl5rwzx7oonzn@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox