From: Jakub Kicinski <kuba@kernel.org>
To: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Oleksij Rempel <linux@rempel-privat.de>,
Dan Williams <dan.j.williams@intel.com>,
Petr Machata <petrm@nvidia.com>,
Hao Chen <chenhao288@hisilicon.com>,
Amit Cohen <amcohen@nvidia.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Sean Anderson <sean.anderson@seco.com>,
linux-kernel@vger.kernel.org,
Leon Romanovsky <leonro@mellanox.com>,
Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [PATCH net-next v3] ethtool: doc: clarify what drivers can implement in their get_drvinfo()
Date: Mon, 14 Nov 2022 21:27:18 -0800 [thread overview]
Message-ID: <20221114212718.76bd6c8b@kernel.org> (raw)
In-Reply-To: <20221113083404.86983-1-mailhol.vincent@wanadoo.fr>
On Sun, 13 Nov 2022 17:34:04 +0900 Vincent Mailhol wrote:
> - * Drivers should set at most @driver, @version, @fw_version and
> - * @bus_info in their get_drvinfo() implementation. The ethtool
> - * core fills in the other fields using other driver operations.
> + * Drivers should set at most @fw_version and @erom_version in their
> + * get_drvinfo() implementation. The ethtool core fills in the other
> + * fields using other driver operations.
Can I still nit pick the working on v3? :)
Almost half of the fields are not filled in by other operations,
so how about we cut deeper? Even @erom_version is only filled in by
a single driver, and pretty much deprecated (devlink is much more
flexible for all FW version reporting and flashing).
How about:
* Majority of the drivers should no longer implement this callback.
* Most fields are correctly filled in by the core using system
* information, or populated using other driver operations.
next prev parent reply other threads:[~2022-11-15 5:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 3:08 [PATCH] ethtool: doc: clarify what drivers can implement in their get_drvinfo() Vincent Mailhol
2022-11-11 6:40 ` [PATCH net-next v2] " Vincent Mailhol
2022-11-13 7:58 ` Leon Romanovsky
2022-11-13 8:34 ` [PATCH net-next v3] " Vincent Mailhol
2022-11-15 5:27 ` Jakub Kicinski [this message]
2022-11-15 7:52 ` Vincent MAILHOL
2022-11-15 16:28 ` Jakub Kicinski
2022-11-16 0:30 ` Vincent MAILHOL
2022-11-16 4:34 ` Vincent MAILHOL
2022-11-16 17:18 ` [PATCH v5] " Vincent Mailhol
2022-11-18 4:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221114212718.76bd6c8b@kernel.org \
--to=kuba@kernel.org \
--cc=amcohen@nvidia.com \
--cc=andrew@lunn.ch \
--cc=chenhao288@hisilicon.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=leonro@mellanox.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=mailhol.vincent@wanadoo.fr \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=sean.anderson@seco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).