From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 646BEC4332F for ; Wed, 16 Nov 2022 16:49:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233016AbiKPQtz (ORCPT ); Wed, 16 Nov 2022 11:49:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233206AbiKPQta (ORCPT ); Wed, 16 Nov 2022 11:49:30 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A6C6E41; Wed, 16 Nov 2022 08:47:13 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4583FB81DFD; Wed, 16 Nov 2022 16:47:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 635BFC433C1; Wed, 16 Nov 2022 16:47:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668617230; bh=Ma1zaxWQ8C5IEvymQzwpG86FF0hqFrdFIAMGPNWoyfc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nNZkd+9c+i31Y+eNwKIMECW6q0wcNHKvGcyMv95cUwC5EJDsNdUznGA3K3/DVYYCV 7qpwF8TAk+YTswLasgXAQKFwnqeNU4WtiXNP68eS08xsufAVDhYjEVglr2+VoUczPk pyzhA/WigMJeaUAOl5R57ivD1uSsq384w00nADSRExImk1XsCMZCNpoMhdylF83uui /z39QOTw7FM4UlO0RtgR/t+z4hDIIo32XZbXaN2+USyQvp6tV6PM9n6+HwzMYhK5/P O+JK8Xt+tGBq/RbUtnetnsMKZt4FDIbkCtHkkP5SQU+0a9lgTqx4GssTdwTFpeHeyZ 7MXLEY+v6IKRw== Date: Wed, 16 Nov 2022 08:47:09 -0800 From: Jakub Kicinski To: Shenwei Wang Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Jesper Dangaard Brouer , Ilias Apalodimas , Alexei Starovoitov , Daniel Borkmann , John Fastabend , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH v5 0/3] net: fec: add xdp and page pool statistics Message-ID: <20221116084709.6b7eeaea@kernel.org> In-Reply-To: <20221115204951.370217-1-shenwei.wang@nxp.com> References: <20221115204951.370217-1-shenwei.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 15 Nov 2022 14:49:48 -0600 Shenwei Wang wrote: > Changes in V5: > - split the patch into two: one for xdp statistics and one for page > pool > - fix the bug to zero xdp_stats array > - use empty 'page_pool_stats' when CONFIG_PAGE_POOL_STATS is disabled. Hi, IIUC there was a previous revision of this set which got applied too hastily. Unfortunately that means you need to rebase on top of what's already applied, or add a revert to your series. Otherwise the patches won't apply cleanly.