From: Jakub Kicinski <kuba@kernel.org>
To: Jerry Ray <jerry.ray@microchip.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [net-next][PATCH v2 2/2] dsa: lan9303: Add 2 ethtool stats
Date: Wed, 16 Nov 2022 09:00:05 -0800 [thread overview]
Message-ID: <20221116090005.6eeb961d@kernel.org> (raw)
In-Reply-To: <20221115165131.11467-2-jerry.ray@microchip.com>
On Tue, 15 Nov 2022 10:51:31 -0600 Jerry Ray wrote:
> Adding RxDropped and TxDropped counters to the reported statistics.
> As these stats are kept by the switch rather than the port instance,
> they are indexed differently.
What are these statistics counting? They are still per port, so should
they be reported in struct rtnl_link_stats::[rt]x_dropped ?
next prev parent reply other threads:[~2022-11-16 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 16:51 [net-next][PATCH v2 1/2] dsa: lan9303: Change stat name Jerry Ray
2022-11-15 16:51 ` [net-next][PATCH v2 2/2] dsa: lan9303: Add 2 ethtool stats Jerry Ray
2022-11-15 17:36 ` Andrew Lunn
2022-11-16 17:00 ` Jakub Kicinski [this message]
2022-11-15 17:30 ` [net-next][PATCH v2 1/2] dsa: lan9303: Change stat name Andrew Lunn
2022-11-16 17:08 ` Florian Fainelli
2022-11-16 17:31 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116090005.6eeb961d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jerry.ray@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).