From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 38702C4332F
	for <netdev@archiver.kernel.org>; Sat, 19 Nov 2022 01:58:03 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233706AbiKSB57 (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 18 Nov 2022 20:57:59 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53908 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233765AbiKSB5n (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 18 Nov 2022 20:57:43 -0500
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD868B30
        for <netdev@vger.kernel.org>; Fri, 18 Nov 2022 17:48:27 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id 743FEB825D8
        for <netdev@vger.kernel.org>; Sat, 19 Nov 2022 01:48:26 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D86CC433C1;
        Sat, 19 Nov 2022 01:48:25 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1668822505;
        bh=VzDrer0bz+FZpawMXS8PurXbPmdnniOqJP03qNEGsdY=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=R7zukn6QOqBHEedtwmT6qGdt51qE63QFCoT4qJ5LAiOLA7fPrQJNsUb/WRu2OU14c
         zDvdvYr/vDI1PvajkQISkzp4VZJQCyQKk8HIDbyZE6l75vXLa6nB8KywVvQXCrVCzx
         NOIu8MlPgXelzSWgmI/xm5sxX2rCGsbbQp7OVrWwne/VAXmz2+IuV0Xh0wUEuWPdrM
         Xpwd7EqTsdre90maf7KXtcwT0/aW/V+vE8nlMv9yBHhHPhjgBgEVymdPpnPB7XWd5/
         LWKcc9WwmSWQkq6BoE2iRYIpGKM60XaFiXqDq8B+UqX4iyY0kC5WUsHIHZHSuca9cf
         UtVBf4oDTa7jA==
Date:   Fri, 18 Nov 2022 17:48:24 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Jacob Keller <jacob.e.keller@intel.com>
Cc:     netdev@vger.kernel.org, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next 5/8] devlink: refactor
 region_read_snapshot_fill to use a callback function
Message-ID: <20221118174824.513e15d8@kernel.org>
In-Reply-To: <20221117220803.2773887-6-jacob.e.keller@intel.com>
References: <20221117220803.2773887-1-jacob.e.keller@intel.com>
        <20221117220803.2773887-6-jacob.e.keller@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Thu, 17 Nov 2022 14:08:00 -0800 Jacob Keller wrote:
> +	/* Allocate and re-use a single buffer */
> +	data = kzalloc(DEVLINK_REGION_READ_CHUNK_SIZE, GFP_KERNEL);
> +	if (!data)
> +		return -ENOMEM;

Why zalloc? If we expect drivers may underfill we should let them
return actual length.