* [PATCH v2] sctp: sm_statefuns: Remove unnecessary ‘NULL’ values from Pointer
@ 2022-11-18 1:46 Li zeming
2022-11-19 3:30 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Li zeming @ 2022-11-18 1:46 UTC (permalink / raw)
To: pabeni, vyasevich, nhorman, marcelo.leitner, davem, edumazet,
kuba
Cc: linux-sctp, netdev, linux-kernel, Li zeming
The 'packet' pointer is always set in the later code, no need to
initialize it at definition time.
Signed-off-by: Li zeming <zeming@nfschina.com>
---
v2: Modify the submitted description.
net/sctp/sm_statefuns.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c
index f6ee7f4040c1..714605746fee 100644
--- a/net/sctp/sm_statefuns.c
+++ b/net/sctp/sm_statefuns.c
@@ -3781,7 +3781,7 @@ static enum sctp_disposition sctp_sf_shut_8_4_5(
void *arg,
struct sctp_cmd_seq *commands)
{
- struct sctp_packet *packet = NULL;
+ struct sctp_packet *packet;
struct sctp_chunk *chunk = arg;
struct sctp_chunk *shut;
--
2.18.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] sctp: sm_statefuns: Remove unnecessary ‘NULL’ values from Pointer
2022-11-18 1:46 [PATCH v2] sctp: sm_statefuns: Remove unnecessary ‘NULL’ values from Pointer Li zeming
@ 2022-11-19 3:30 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-11-19 3:30 UTC (permalink / raw)
To: Li zeming
Cc: pabeni, vyasevich, nhorman, marcelo.leitner, davem, edumazet,
linux-sctp, netdev, linux-kernel
On Fri, 18 Nov 2022 09:46:42 +0800 Li zeming wrote:
> - struct sctp_packet *packet = NULL;
> + struct sctp_packet *packet;
> struct sctp_chunk *chunk = arg;
> struct sctp_chunk *shut;
Please don't sent such patches to networking.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-19 3:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-18 1:46 [PATCH v2] sctp: sm_statefuns: Remove unnecessary ‘NULL’ values from Pointer Li zeming
2022-11-19 3:30 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).