From: Christoph Hellwig <hch@lst.de>
To: Greg Ungerer <gerg@linux-m68k.org>,
Joakim Zhang <qiangqing.zhang@nxp.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-m68k@lists.linux-m68k.org, uclinux-dev@uclinux.org,
netdev@vger.kernel.org
Subject: [PATCH 2/2] m68k: return NULL from dma_alloc_coherent for nommu or coldfire
Date: Mon, 21 Nov 2022 10:56:31 +0100 [thread overview]
Message-ID: <20221121095631.216209-3-hch@lst.de> (raw)
In-Reply-To: <20221121095631.216209-1-hch@lst.de>
m68knommu and coldfire platforms can't support allocating coherent DMA
memory. Instead of just returning noncoherent memory, just fail the
allocation.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
arch/m68k/kernel/dma.c | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/arch/m68k/kernel/dma.c b/arch/m68k/kernel/dma.c
index 2e192a5df949b..63618fce5dc7f 100644
--- a/arch/m68k/kernel/dma.c
+++ b/arch/m68k/kernel/dma.c
@@ -37,23 +37,13 @@ pgprot_t pgprot_dmacoherent(pgprot_t prot)
void *arch_dma_alloc(struct device *dev, size_t size, dma_addr_t *dma_handle,
gfp_t gfp, unsigned long attrs)
{
- void *ret;
-
- if (dev == NULL || (*dev->dma_mask < 0xffffffff))
- gfp |= GFP_DMA;
- ret = (void *)__get_free_pages(gfp, get_order(size));
-
- if (ret != NULL) {
- memset(ret, 0, size);
- *dma_handle = virt_to_phys(ret);
- }
- return ret;
+ return NULL;
}
void arch_dma_free(struct device *dev, size_t size, void *vaddr,
dma_addr_t dma_handle, unsigned long attrs)
{
- free_pages((unsigned long)vaddr, get_order(size));
+ WARN_ON_ONCE(1);
}
#endif /* CONFIG_MMU && !CONFIG_COLDFIRE */
--
2.30.2
prev parent reply other threads:[~2022-11-21 9:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 9:56 fix dma_alloc_coherent on m68knommu / coldfire Christoph Hellwig
2022-11-21 9:56 ` [PATCH 1/2] net: fec: use dma_alloc_noncoherent for m532x Christoph Hellwig
2022-11-21 10:24 ` Geert Uytterhoeven
2022-11-21 10:43 ` Christoph Hellwig
2022-12-01 5:41 ` Greg Ungerer
2022-12-02 7:02 ` Christoph Hellwig
2022-12-05 14:09 ` Greg Ungerer
2022-11-21 9:56 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121095631.216209-3-hch@lst.de \
--to=hch@lst.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=kuba@kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qiangqing.zhang@nxp.com \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).