From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: <netdev@vger.kernel.org>, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next 3/8] devlink: report extended error message in region_read_dumpit
Date: Mon, 21 Nov 2022 11:23:22 -0800 [thread overview]
Message-ID: <20221121112322.21bffb4b@kernel.org> (raw)
In-Reply-To: <243100a2-abb4-6df4-235e-42a773716309@intel.com>
On Mon, 21 Nov 2022 11:10:37 -0800 Jacob Keller wrote:
> >> @@ -6453,8 +6453,14 @@ static int devlink_nl_cmd_region_read_dumpit(struct sk_buff *skb,
> >>
> >> devl_lock(devlink);
> >>
> >> - if (!attrs[DEVLINK_ATTR_REGION_NAME] ||
> >> - !attrs[DEVLINK_ATTR_REGION_SNAPSHOT_ID]) {
> >> + if (!attrs[DEVLINK_ATTR_REGION_NAME]) {
> >> + NL_SET_ERR_MSG_MOD(cb->extack, "No region name provided");
> >> + err = -EINVAL;
> >> + goto out_unlock;
> >> + }
> >> +
> >> + if (!attrs[DEVLINK_ATTR_REGION_SNAPSHOT_ID]) {
> >
> > Please use GENL_REQ_ATTR_CHECK() instead of adding strings.
> >
>
> Ahhh. Figured out why GENL_REQ_ATTR_CHECK wasn't used here already. It
> happens because the dumpit functions don't get a genl_info * struct,
> they get a netlink_cb and a genl_dumpit_info.
>
> I can look at improving this.
Ah damn, you're right, I thought I just missed it because it wasn't
at the top of the function.
next prev parent reply other threads:[~2022-11-21 19:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 22:07 [PATCH net-next 0/8] devlink: support direct read from region Jacob Keller
2022-11-17 22:07 ` [PATCH net-next 1/8] devlink: find snapshot in devlink_nl_cmd_region_read_dumpit Jacob Keller
2022-11-17 22:07 ` [PATCH net-next 2/8] devlink: use min_t to calculate data_size Jacob Keller
2022-11-19 1:36 ` Jakub Kicinski
2022-11-21 17:51 ` Jacob Keller
2022-11-21 18:35 ` Jacob Keller
2022-11-21 19:06 ` Jakub Kicinski
2022-11-21 21:16 ` Jacob Keller
2022-11-17 22:07 ` [PATCH net-next 3/8] devlink: report extended error message in region_read_dumpit Jacob Keller
2022-11-19 1:40 ` Jakub Kicinski
2022-11-21 17:53 ` Jacob Keller
2022-11-21 19:10 ` Jacob Keller
2022-11-21 19:23 ` Jakub Kicinski [this message]
2022-11-21 21:18 ` Jacob Keller
2022-11-22 4:07 ` Jakub Kicinski
2022-11-17 22:07 ` [PATCH net-next 4/8] devlink: remove unnecessary parameter from chunk_fill function Jacob Keller
2022-11-17 22:08 ` [PATCH net-next 5/8] devlink: refactor region_read_snapshot_fill to use a callback function Jacob Keller
2022-11-19 1:31 ` Jakub Kicinski
2022-11-19 1:48 ` Jakub Kicinski
2022-11-21 17:55 ` Jacob Keller
2022-11-17 22:08 ` [PATCH net-next 6/8] devlink: support directly reading from region memory Jacob Keller
2022-11-19 1:49 ` Jakub Kicinski
2022-11-23 19:20 ` Jacob Keller
2022-11-17 22:08 ` [PATCH net-next 7/8] ice: use same function to snapshot both NVM and Shadow RAM Jacob Keller
2022-11-17 22:08 ` [PATCH net-next 8/8] ice: implement direct read for NVM and Shadow RAM regions Jacob Keller
2022-11-23 20:51 ` [PATCH net-next 0/8] devlink: support direct read from region Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121112322.21bffb4b@kernel.org \
--to=kuba@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).