From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EBA4C433FE for ; Mon, 21 Nov 2022 20:18:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230209AbiKUUSK (ORCPT ); Mon, 21 Nov 2022 15:18:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbiKUUSI (ORCPT ); Mon, 21 Nov 2022 15:18:08 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18807BE86A; Mon, 21 Nov 2022 12:18:08 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 60A8ECE18E3; Mon, 21 Nov 2022 20:18:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7C7EC433D6; Mon, 21 Nov 2022 20:18:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669061884; bh=IhNl1vJm3VXqLz/ACfcWWRbRVPnFw5gG6KxRJkVvCnA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lxUWsUEPCrFrZwmJ6lNTMZOQFI44VAboWP7tjFx/pVRPWovDYI4i5cPpy/6KUJGNg OI4+n/0mmTC1k7r98QA+zMbNSZuulwXCQPpP0tN/NedQjlCcjv3qNodgraUNJzkb1k b0greRQNwn4uhMPxVMJlD0x71Iu05YKJlsVK817AEVr2WdWdEkLyJtkhyArjGEMA3u kltB4rJmyfEj/C1p6c5lo0k1O/Aqf2K9nANgcCSqLIAlImpdUMzmK0cg5Bn8ZBF7U0 JXT+ZYBP65Dk4te31iG353KqFaUQnVVnxcr8NrDyADFAshMSeMn/6WT/K3fUauGbXz AysDyZtShvHdA== Date: Mon, 21 Nov 2022 12:18:03 -0800 From: Jakub Kicinski To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Trond Myklebust , Anna Schumaker , Roopa Prabhu , Nikolay Aleksandrov , "David S. Miller" , Eric Dumazet , Paolo Abeni , Chuck Lever , Jeff Layton , linux-nfs@vger.kernel.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH 1/5] kobject: make kobject_get_ownership() take a constant kobject * Message-ID: <20221121121803.31962489@kernel.org> In-Reply-To: <20221121094649.1556002-1-gregkh@linuxfoundation.org> References: <20221121094649.1556002-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 21 Nov 2022 10:46:45 +0100 Greg Kroah-Hartman wrote: > The call, kobject_get_ownership(), does not modify the kobject passed > into it, so make it const. This propagates down into the kobj_type > function callbacks so make the kobject passed into them also const, > ensuring that nothing in the kobject is being changed here. > > This helps make it more obvious what calls and callbacks do, and do not, > modify structures passed to them. Acked-by: Jakub Kicinski