From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Nikolay Borisov <nikolay.borisov@virtuozzo.com>,
nhorman@tuxdriver.com, davem@davemloft.net, pabeni@redhat.com,
netdev@vger.kernel.org, den@virtuozzo.com,
khorenko@virtuozzo.com
Subject: Re: [PATCH net-next 1/3] drop_monitor: Implement namespace filtering/reporting for software drops
Date: Mon, 21 Nov 2022 12:23:49 -0800 [thread overview]
Message-ID: <20221121122349.3b217935@kernel.org> (raw)
In-Reply-To: <Y3uKNf53EkKMmVwh@nanopsycho>
On Mon, 21 Nov 2022 15:24:53 +0100 Jiri Pirko wrote:
> >+ NET_DM_ATTR_NS, /* u32 */
>
> I believe that we need to add a CI warning for this kind of UAPI
> breakage...
Do you have any ideas on how to code it up in python?
I don't think we let too many such errors thru.
Nikolay, you can't add in the middle of an enum in uAPI because binary
backward compatibility would break. Always add attrs at the end / before
the "cnt" or "max" member.
next prev parent reply other threads:[~2022-11-21 20:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 13:31 [PATCH net-next 0/3] Add support for netnamespace filtering in drop monitor Nikolay Borisov
2022-11-21 13:31 ` [PATCH net-next 1/3] drop_monitor: Implement namespace filtering/reporting for software drops Nikolay Borisov
2022-11-21 14:24 ` Jiri Pirko
2022-11-21 20:23 ` Jakub Kicinski [this message]
2022-11-21 13:31 ` [PATCH net-next 2/3] drop_monitor: Add namespace filtering/reporting for hardware drops Nikolay Borisov
2022-11-21 13:31 ` [PATCH net-next 3/3] selftests: net: Add drop monitor tests for namespace filtering functionality Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121122349.3b217935@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=den@virtuozzo.com \
--cc=jiri@resnulli.us \
--cc=khorenko@virtuozzo.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=nikolay.borisov@virtuozzo.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).