From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 00/17] Remove dsa_priv.h
Date: Mon, 21 Nov 2022 22:28:48 +0200 [thread overview]
Message-ID: <20221121202848.mrtvv6a27qq5ftv6@skbuf> (raw)
In-Reply-To: <260e9aa4-cc62-7cb9-f899-a30c1e802868@gmail.com>
On Mon, Nov 21, 2022 at 11:16:07AM -0800, Florian Fainelli wrote:
> This all looks fine on paper, only concern is that it will make our lives so
> much more miserable for back porting fixes into older kernels, if you are
> fine with that as a co-maintainer, then so am I.
>
> That argument could always be used to make zero re-structuring and it would
> be sad for DSA to ossify, so obviously should not be the major reason for
> not making changes.
I think the opposite of restructuring is not ossification as you say,
but rather disorganized growth which will become even harder to
disentangle later on.
The next step (at some point) is going to be reorganization of what gets
exported to include/net/dsa.h and how, since to me, there's already a
worrying amount of uncontrolled information being scavenged by certain
DSA master drivers, even if the intended recipient for that header is
switch drivers. I didn't start with include/net/dsa.h because, well,
I think first you need to make your own bed before you rule the world,
but in general, what is here can be seen only a small piece of what's to
come.
I'm not sure what to say about backports.. it doesn't scare me too much.
Maybe that's also the lack of experience speaking.
next prev parent reply other threads:[~2022-11-21 20:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 13:55 [PATCH net-next 00/17] Remove dsa_priv.h Vladimir Oltean
2022-11-21 13:55 ` [PATCH net-next 01/17] net: dsa: unexport dsa_dev_to_net_device() Vladimir Oltean
2022-11-21 19:56 ` Florian Fainelli
2022-11-21 13:55 ` [PATCH net-next 02/17] net: dsa: modularize DSA_TAG_PROTO_NONE Vladimir Oltean
2022-11-21 19:56 ` Florian Fainelli
2022-11-21 13:55 ` [PATCH net-next 03/17] net: dsa: move bulk of devlink code to devlink.{c,h} Vladimir Oltean
2022-11-21 19:57 ` Florian Fainelli
2022-11-21 13:55 ` [PATCH net-next 04/17] net: dsa: if ds->setup is true, ds->devlink is always non-NULL Vladimir Oltean
2022-11-21 19:58 ` Florian Fainelli
2022-11-21 13:55 ` [PATCH net-next 05/17] net: dsa: move rest of devlink setup/teardown to devlink.c Vladimir Oltean
2022-11-21 19:58 ` Florian Fainelli
2022-11-21 13:55 ` [PATCH net-next 06/17] net: dsa: move headers exported by port.c to port.h Vladimir Oltean
2022-11-21 19:59 ` Florian Fainelli
2022-11-21 13:55 ` [PATCH net-next 07/17] net: dsa: move headers exported by master.c to master.h Vladimir Oltean
2022-11-21 19:59 ` Florian Fainelli
2022-11-21 13:55 ` [PATCH net-next 08/17] net: dsa: move headers exported by slave.c to slave.h Vladimir Oltean
2022-11-21 20:00 ` Florian Fainelli
2022-11-21 13:55 ` [PATCH net-next 09/17] net: dsa: move tagging protocol code to tag.{c,h} Vladimir Oltean
2022-11-21 20:33 ` Florian Fainelli
2022-11-21 13:55 ` [PATCH net-next 10/17] net: dsa: move headers exported by switch.c to switch.h Vladimir Oltean
2022-11-21 20:34 ` Florian Fainelli
2022-11-21 13:55 ` [PATCH net-next 11/17] net: dsa: move dsa_tree_notify() and dsa_broadcast() to switch.c Vladimir Oltean
2022-11-21 20:34 ` Florian Fainelli
2022-11-21 13:55 ` [PATCH net-next 12/17] net: dsa: move notifier definitions to switch.h Vladimir Oltean
2022-11-21 20:35 ` Florian Fainelli
2022-11-21 13:55 ` [PATCH net-next 13/17] net: dsa: merge dsa.c into dsa2.c Vladimir Oltean
2022-11-21 20:36 ` Florian Fainelli
2022-11-21 13:55 ` [PATCH net-next 14/17] net: dsa: rename dsa2.c back into dsa.c and create its header Vladimir Oltean
2022-11-21 20:37 ` Florian Fainelli
2022-11-21 13:55 ` [PATCH net-next 15/17] net: dsa: move definitions from dsa_priv.h to slave.c Vladimir Oltean
2022-11-21 20:37 ` Florian Fainelli
2022-11-21 13:55 ` [PATCH net-next 16/17] net: dsa: move tag_8021q headers to their proper place Vladimir Oltean
2022-11-21 20:38 ` Florian Fainelli
2022-11-21 13:55 ` [PATCH net-next 17/17] net: dsa: kill off dsa_priv.h Vladimir Oltean
2022-11-21 20:38 ` Florian Fainelli
2022-11-21 19:16 ` [PATCH net-next 00/17] Remove dsa_priv.h Florian Fainelli
2022-11-21 20:28 ` Vladimir Oltean [this message]
2022-11-23 4:52 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121202848.mrtvv6a27qq5ftv6@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).