From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AED47C433FE for ; Tue, 22 Nov 2022 02:29:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231906AbiKVC3a (ORCPT ); Mon, 21 Nov 2022 21:29:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231675AbiKVC3B (ORCPT ); Mon, 21 Nov 2022 21:29:01 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEDAF2E69E for ; Mon, 21 Nov 2022 18:28:36 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B458A61534 for ; Tue, 22 Nov 2022 02:28:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10D2AC433C1; Tue, 22 Nov 2022 02:28:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669084116; bh=IV99aF/LKZzKTFhC7P+bY9zyaQuPIcwTwHYGZfpAtnc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OaLoN8JaWRY7s4tBGrOtaKSPscRx9gG7dP3rgyoIE3RketrgIv3PkseqJA7SZgqPW yucGZIVygtw3OwZW1MTjd7FibapyWeueaNc0iA7y/zEQLcRT7/C942dmNJiuT198ex doAeyhO9u85hnkl+Iq1SrDwm3FTxiHAzjZbhr/NoYc1/6G27mJ4/OB4J7KFktl9p1u clUF0YSpAlc3iuvhU5LEN4ugXRekJZHRlzThXQuk4h4zvUCwISVOXyNQfikbbwjt7A 5xhAXryRg3I6IxALhjxPTFD2nLO/etuDBJZ+k44zAvFuDNH7ug4RakF6q3iplhTu/L EHD1z9zuJ4Ong== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Emeel Hakim , Raed Salem Subject: [net 13/14] net/mlx5e: Fix MACsec update SecY Date: Mon, 21 Nov 2022 18:25:58 -0800 Message-Id: <20221122022559.89459-14-saeed@kernel.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221122022559.89459-1-saeed@kernel.org> References: <20221122022559.89459-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Emeel Hakim Currently updating SecY destroys and re-creates RX SA objects, the re-created RX SA objects are not identical to the destroyed objects and it disagree on the encryption enabled property which holds the value false after recreation, this value is not supported with offload which leads to no traffic after an update. Fix by recreating an identical objects. Fixes: 5a39816a75e5 ("net/mlx5e: Add MACsec offload SecY support") Signed-off-by: Emeel Hakim Reviewed-by: Raed Salem Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c index 8f8a735a4501..4f96c69c6cc4 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c @@ -1155,7 +1155,7 @@ static int macsec_upd_secy_hw_address(struct macsec_context *ctx, continue; if (rx_sa->active) { - err = mlx5e_macsec_init_sa(ctx, rx_sa, false, false); + err = mlx5e_macsec_init_sa(ctx, rx_sa, true, false); if (err) goto out; } -- 2.38.1