From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70AB3C43219 for ; Tue, 22 Nov 2022 15:38:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233142AbiKVPik (ORCPT ); Tue, 22 Nov 2022 10:38:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232849AbiKVPif (ORCPT ); Tue, 22 Nov 2022 10:38:35 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0552E1DD; Tue, 22 Nov 2022 07:38:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 91557B81BE7; Tue, 22 Nov 2022 15:38:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BF2CC433D6; Tue, 22 Nov 2022 15:38:28 +0000 (UTC) Date: Tue, 22 Nov 2022 10:38:26 -0500 From: Steven Rostedt To: Thomas Gleixner Cc: LKML , Linus Torvalds , Anna-Maria Behnsen , Peter Zijlstra , Stephen Boyd , Guenter Roeck , Andrew Morton , Julia Lawall , Arnd Bergmann , Viresh Kumar , Marc Zyngier , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Jonathan Corbet Subject: Re: [patch 06/15] timers: Update kernel-doc for various functions Message-ID: <20221122103826.319644d0@gandalf.local.home> In-Reply-To: <878rk3ggqa.ffs@tglx> References: <20221115195802.415956561@linutronix.de> <20221115202117.323694948@linutronix.de> <20221121154358.36856ca6@gandalf.local.home> <878rk3ggqa.ffs@tglx> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 22 Nov 2022 16:18:37 +0100 Thomas Gleixner wrote: > >> * > >> - * The function returns whether it has deactivated a pending timer or not. > >> - * (ie. del_timer() of an inactive timer returns 0, del_timer() of an > >> - * active timer returns 1.) > >> + * Contrary to del_timer_sync() this function does not wait for an > >> + * eventually running timer callback on a different CPU and it neither > > > > I'm a little confused with the "eventually running timer". Does that simply > > mean one that is about to run next (that is, it doesn't handle race > > conditions and the timer is in the process of starting), but will still > > deactivate one that has not been started and the timer code for that CPU > > hasn't triggered yet? > > Let me try again. > > The function only deactivates a pending timer, but contrary to > del_timer_sync() it does not take into account whether the timers > callback function is concurrently executed on a different CPU or not. > > Does that make more sense? Yes, much better. Thanks! -- Steve