From: Kees Cook <keescook@chromium.org>
To: edward.cree@amd.com
Cc: netdev@vger.kernel.org, linux-net-drivers@amd.com,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, habetsm.xilinx@gmail.com,
Edward Cree <ecree.xilinx@gmail.com>
Subject: Re: [PATCH net-next] sfc: ensure type is valid before updating seen_gen
Date: Tue, 22 Nov 2022 21:17:30 -0800 [thread overview]
Message-ID: <202211222117.40BF455@keescook> (raw)
In-Reply-To: <20221121213708.13645-1-edward.cree@amd.com>
On Mon, Nov 21, 2022 at 09:37:08PM +0000, edward.cree@amd.com wrote:
> From: Edward Cree <ecree.xilinx@gmail.com>
>
> In the case of invalid or corrupted v2 counter update packets,
> efx_tc_rx_version_2() returns EFX_TC_COUNTER_TYPE_MAX. In this case
> we should not attempt to update generation counts as this will write
> beyond the end of the seen_gen array.
>
> Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
> Addresses-Coverity-ID: 1527356 ("Memory - illegal accesses")
> Fixes: 25730d8be5d8 ("sfc: add extra RX channel to receive MAE counter updates on ef100")
> Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2022-11-23 5:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 21:37 [PATCH net-next] sfc: ensure type is valid before updating seen_gen edward.cree
2022-11-23 5:17 ` Kees Cook [this message]
2022-11-23 13:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202211222117.40BF455@keescook \
--to=keescook@chromium.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=edward.cree@amd.com \
--cc=habetsm.xilinx@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).