Netdev List
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Steve Williams <steve.williams@getcruise.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, vinicius.gomes@intel.com,
	xiaoliang.yang_1@nxp.com, Jiri Pirko <jiri@resnulli.us>,
	Andrew Lunn <andrew@lunn.ch>
Subject: Re: [EXT] Re: [PATCH net-next] net/hanic: Add the hanic network interface for high availability links
Date: Wed, 23 Nov 2022 16:26:14 +0200	[thread overview]
Message-ID: <20221123142558.akqff2gtvzrqtite@skbuf> (raw)
In-Reply-To: <CALHoRjcw8Du+4Px__x=vfDfjKnHVRnMmAhBBEznQ2CfHPZ9S0A@mail.gmail.com>

On Tue, Nov 22, 2022 at 12:51:53PM -0800, Steve Williams wrote:
> This driver provides a way for outbound traffic to be tagged and duplicated out
> multiple ports, and inbound R-TAG'ed packets to be deduplicated.

> Hanic tries to make the R-TAG handling transparent,

> Generic filtering and/or dynamic stream identification methods just seemed
> out of scope for this driver. Certainly out of scope for our needs.

> Yes, hanic implements a practical subset of the standard, and I try to be
> clear about that in the documentation.

I'm back with a more intelligent question, after looking a bit at the
code and at the problem it tries to solve.

The question is: why don't you create a tap interface, and a user space
program which is given the physical ports and tap interface as command
line arguments, and does the following:

- on reception from physical interfaces, handles 802.1CB traffic from
  physical ports, eliminates the duplicates and pops the R-TAG, then
  sends the packets to the tap interface
- handles packets transmitted to the tap, splits them and pushes
  whatever R-TAG is needed, then forwards them to the physical network
  interfaces

Then your Cruise 802.1CB endpoint solution becomes a user space handler
for a tap interface. To users of your solution, it's the same thing,
except they open their socket on a tap interface and not on a hanic
interface.

Reworded, why must the hanic functionality to be in the kernel?

Thank you.

  reply	other threads:[~2022-11-23 14:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18 23:26 [PATCH net-next] net/hanic: Add the hanic network interface for high availability links Steve Williams
2022-11-22  0:40 ` Andrew Lunn
2022-11-22  3:58 ` Jakub Kicinski
2022-11-22 11:34   ` Vladimir Oltean
2022-11-22 19:54     ` Andrew Lunn
2022-11-22 21:01       ` [EXT] " Steve Williams
2022-11-22 20:51     ` Steve Williams
2022-11-23 14:26       ` Vladimir Oltean [this message]
2022-11-23 14:52         ` Jiri Pirko
2022-11-23 15:12           ` Andrew Lunn
2023-02-21 11:03             ` Ferenc Fejes
2022-11-23 15:25           ` Vladimir Oltean
2022-11-23 16:36             ` Jiri Pirko
2022-11-29 22:38               ` Steve Williams
2022-11-22 12:49 ` Jiri Pirko
2022-11-22 13:55   ` Vladimir Oltean
2022-11-22 14:06     ` Jiri Pirko
2022-11-22 20:57     ` [EXT] " Steve Williams
2022-11-23 12:46       ` Jiri Pirko
2023-02-21 10:56 ` Ferenc Fejes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221123142558.akqff2gtvzrqtite@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=andrew@lunn.ch \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=steve.williams@getcruise.com \
    --cc=vinicius.gomes@intel.com \
    --cc=xiaoliang.yang_1@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox